Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[clang-format] Parse volatile as a pointer qualifier
ClosedPublic
Actions

Authored by arichardson on Aug 27 2020, 6:41 AM.

Details

Reviewers

MyDeveloperDay
JakeMerdichAMD
sammccall
curdeius

Commits

rG1908da2658fc: [clang-format] Parse volatile as a pointer qualifier

Summary

Before: void f() { MACRO(A * volatile a); }
After: void f() { MACRO(A *volatile a); }

Also check that the volatile and volatile__ aliases are handled.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

arichardson created this revision.Aug 27 2020, 6:41 AM

Herald added a project: Restricted Project. · View Herald TranscriptAug 27 2020, 6:41 AM

Herald added a subscriber: cfe-commits. · View Herald Transcript

arichardson requested review of this revision.Aug 27 2020, 6:41 AM

LGTM. Wait a bit to give others a chance to chime in before submitting.

This revision is now accepted and ready to land.Aug 27 2020, 6:57 AM

Harbormaster completed remote builds in B69771: Diff 288310.Aug 27 2020, 7:16 AM

arichardson added a child revision: D86710: [clang-format] Parse restrict as a pointer qualifier.Aug 27 2020, 8:15 AM

Closed by commit rG1908da2658fc: [clang-format] Parse volatile as a pointer qualifier (authored by arichardson). · Explain WhyAug 28 2020, 3:32 AM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rG1908da2658fc: [clang-format] Parse volatile as a pointer qualifier.

Revision Contents
Changeset List

Path

Size

clang/

lib/

Format/

TokenAnnotator.cpp

2 lines

unittests/

Format/

FormatTest.cpp

3 lines

Diff 288571

View Options

clang/lib/Format/TokenAnnotator.cpp