Page MenuHomePhabricator

[mlir] Fix bug in block merging when the types of the operands differ
ClosedPublic

Authored by rriddle on Aug 26 2020, 1:01 AM.

Details

Summary

The merging algorithm was previously not checking for type equivalence.

Fixes PR47314

Diff Detail

Event Timeline

rriddle created this revision.Aug 26 2020, 1:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 26 2020, 1:01 AM
rriddle requested review of this revision.Aug 26 2020, 1:01 AM
mehdi_amini accepted this revision.Aug 26 2020, 1:05 AM

LGTM

mlir/test/Transforms/canonicalize-block-merge.mlir
206

You're not checking anything here though, just relying on the verifier?

This revision is now accepted and ready to land.Aug 26 2020, 1:05 AM
rriddle updated this revision to Diff 287857.Aug 26 2020, 1:13 AM

Address comments

rriddle marked an inline comment as done.Aug 26 2020, 1:14 AM
This revision was landed with ongoing or failed builds.Aug 26 2020, 1:17 AM
This revision was automatically updated to reflect the committed changes.