This is an archive of the discontinued LLVM Phabricator instance.

[Attributor] fix AANoUndef initialization
ClosedPublic

Authored by okura on Aug 21 2020, 11:16 AM.

Details

Summary

Currently, AANoUndefImpl::initialize mistakenly always indicates optimistic fixpoint for function returned position.
This is because an associated value is Function in the case, and isGuaranteedNotToBeUndefOrPoison returns true for Function.

Diff Detail

Event Timeline

okura created this revision.Aug 21 2020, 11:16 AM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
okura requested review of this revision.Aug 21 2020, 11:16 AM
jdoerfert added inline comments.Aug 21 2020, 11:56 AM
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
7718–7719

can we check the position kind instead? This impacts function pointers as well.

okura updated this revision to Diff 287080.Aug 21 2020, 12:20 PM
  • change to check IR position
okura marked an inline comment as done.Aug 21 2020, 12:20 PM
okura updated this revision to Diff 287086.Aug 21 2020, 12:52 PM
  • delete unnecessary format change
jdoerfert accepted this revision.Aug 21 2020, 1:01 PM

LGTM thx

This revision is now accepted and ready to land.Aug 21 2020, 1:01 PM
This revision was automatically updated to reflect the committed changes.