This is an archive of the discontinued LLVM Phabricator instance.

[flang] Fix assert on bad character kind
ClosedPublic

Authored by tskeith on Aug 21 2020, 10:00 AM.

Details

Summary

When we report an error for a bad character kind, don't keep it in the
DeclTypeSpec. Otherwise there could be further problems. In this case,
ComputeOffsets() got an assertion error because we didn't recognize
CHARACTER(*,8) as needing a descriptor because of the bad kind.

Fixes https://bugs.llvm.org/show_bug.cgi?id=47173

Diff Detail

Event Timeline

tskeith created this revision.Aug 21 2020, 10:00 AM
Herald added a project: Restricted Project. · View Herald Transcript
tskeith requested review of this revision.Aug 21 2020, 10:00 AM
klausler accepted this revision.Aug 21 2020, 10:02 AM
This revision is now accepted and ready to land.Aug 21 2020, 10:02 AM
sscalpone accepted this revision.Aug 21 2020, 12:07 PM
This revision was automatically updated to reflect the committed changes.