This is an archive of the discontinued LLVM Phabricator instance.

Differential D86144

[lldb] [testsuite] Add split-file for check-lldb dependencies
ClosedPublic

Authored by jankratochvil on Aug 18 2020, 8:52 AM.

Details

Reviewers
labath
MaskRay
Commits
rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies
Summary

D85968 started to use split-file and while buildbots run fine while doing make check-lldb by hand I get:

.../llvm-monorepo-clangassert/tools/lldb/test/SymbolFile/DWARF/Output/DW_AT_declaration-with-children.s.script: line 2: split-file: command not found
failed:
  lldb-shell :: SymbolFile/DWARF/DW_AT_declaration-with-children.s

Diff Detail

Event Timeline

jankratochvil created this revision.Aug 18 2020, 8:52 AM
Herald added subscribers: JDevlieghere, aprantl, mgorny. · View Herald TranscriptAug 18 2020, 8:52 AM
jankratochvil requested review of this revision.Aug 18 2020, 8:52 AM
labath accepted this revision.Aug 18 2020, 8:56 AM

Thanks for catching that.

lldb/test/CMakeLists.txt
81

Please keep this list sorted.

This revision is now accepted and ready to land.Aug 18 2020, 8:56 AM
This revision was landed with ongoing or failed builds.Aug 18 2020, 9:11 AM
Closed by commit rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies (authored by jankratochvil). · Explain Why
This revision was automatically updated to reflect the committed changes.
jankratochvil added a commit: rG7baed769c7ea: [lldb] [testsuite] Add split-file for check-lldb dependencies.
Harbormaster completed remote builds in B68760: Diff 286291.Aug 18 2020, 9:17 AM

Revision Contents

PathSize
lldb/
test/
1 line

Diff 286291

lldb/test/CMakeLists.txt

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines
if(NOT LLDB_BUILT_STANDALONE) if(NOT LLDB_BUILT_STANDALONE)
add_lldb_test_dependency( add_lldb_test_dependency(
FileCheck FileCheck
count count
dsymutil dsymutil
llvm-strip llvm-strip
not not
yaml2obj yaml2obj
split-file
labathUnsubmitted
Not Done
ReplyInline Actions

Please keep this list sorted.

labath: Please keep this list sorted.
) )
endif() endif()
# Add dependencies if we test with the in-tree clang. # Add dependencies if we test with the in-tree clang.
# This works with standalone builds as they import the clang target. # This works with standalone builds as they import the clang target.
if(TARGET clang) if(TARGET clang)
add_lldb_test_dependency(clang) add_lldb_test_dependency(clang)
▲ Show 20 Lines • Show All 136 Lines • Show Last 20 Lines