This is an archive of the discontinued LLVM Phabricator instance.

Differential D86128

[Attributor][NFC] Add tests to range.ll
ClosedPublic

Authored by okura on Aug 17 2020, 9:57 PM.

Details

Reviewers
uenoku
homerdin
jdoerfert
sstefan1
baziotis
Commits
rG21e4b9b204b4: [Attributor][NFC] Add tests to range.ll

Diff Detail

Event Timeline

okura created this revision.Aug 17 2020, 9:57 PM
Herald added a reviewer: uenoku. · View Herald TranscriptAug 17 2020, 9:57 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, kuter, uenoku. · View Herald Transcript
okura requested review of this revision.Aug 17 2020, 9:57 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptAug 17 2020, 9:57 PM
Herald added a reviewer: sstefan1. · View Herald Transcript
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a subscriber: bbn. · View Herald Transcript
okura updated this revision to Diff 286214.Aug 18 2020, 1:30 AM
  • add more tests
jdoerfert added inline comments.Aug 18 2020, 8:28 AM
llvm/test/Transforms/Attributor/range.ll
1766

What is the difference to less_than_100_1?

okura added inline comments.Aug 18 2020, 11:32 AM
llvm/test/Transforms/Attributor/range.ll
1766

(less_than_100 | is_less_than_100) _1 and _2 are the same (respectively). I duplicate them because I want to split propagate_range1 and propagate_range2 completely.
When I handle CallBase in AAValueConstantRange::initialize, the value will be simplified in the former case and will not in the latter case. However, If we use the same less_than_100 and is_less_than_100 in both tests, the value will be simplified in both cases.

jdoerfert accepted this revision.Aug 18 2020, 12:22 PM

LGTM.

llvm/test/Transforms/Attributor/range.ll
1766

makes sense.

This revision is now accepted and ready to land.Aug 18 2020, 12:22 PM
Closed by commit rG21e4b9b204b4: [Attributor][NFC] Add tests to range.ll (authored by okura). · Explain WhyAug 18 2020, 11:02 PM
This revision was automatically updated to reflect the committed changes.
okura added a commit: rG21e4b9b204b4: [Attributor][NFC] Add tests to range.ll.

Revision Contents

PathSize
llvm/
test/
Transforms/
Attributor/
261 lines

Diff 286200

llvm/test/Transforms/Attributor/range.ll

Show First 20 Lines • Show All 1,406 Lines • ▼ Show 20 Lines
t: t:
%ret1 = call i32 @func(i1 %c) %ret1 = call i32 @func(i1 %c)
ret i32 %ret1 ret i32 %ret1
f: f:
%ret2 = call i32 @func(i1 false) %ret2 = call i32 @func(i1 false)
ret i32 %ret2 ret i32 %ret2
} }
define internal i32 @less_than_65536(i32 %arg) {
; IS__TUNIT____: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT____-LABEL: define {{[^@]+}}@less_than_65536
; IS__TUNIT____-SAME: (i32 [[ARG:%.*]])
; IS__TUNIT____-NEXT: [[SHRINKED:%.*]] = udiv i32 [[ARG]], 65536
; IS__TUNIT____-NEXT: ret i32 [[SHRINKED]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@less_than_65536
; IS__CGSCC____-SAME: (i32 [[ARG:%.*]])
; IS__CGSCC____-NEXT: [[SHRINKED:%.*]] = udiv i32 [[ARG]], 65536
; IS__CGSCC____-NEXT: ret i32 [[SHRINKED]]
;
%shrinked = udiv i32 %arg, 65536
ret i32 %shrinked
}
define internal i1 @is_less_than_65536(i32 %arg) {
; IS__TUNIT____: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT____-LABEL: define {{[^@]+}}@is_less_than_65536
; IS__TUNIT____-SAME: (i32 [[ARG:%.*]])
; IS__TUNIT____-NEXT: [[CMP:%.*]] = icmp ult i32 [[ARG]], 65536
; IS__TUNIT____-NEXT: ret i1 [[CMP]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@is_less_than_65536
; IS__CGSCC____-SAME: (i32 [[ARG:%.*]])
; IS__CGSCC____-NEXT: [[CMP:%.*]] = icmp ult i32 [[ARG]], 65536
; IS__CGSCC____-NEXT: ret i1 [[CMP]]
;
%cmp = icmp ult i32 %arg, 65536
ret i1 %cmp
}
; FIXME: returned value can be simplified to i1 true
define i1 @check_divided_range(i32 %arg) {
; IS__TUNIT_OPM: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT_OPM-LABEL: define {{[^@]+}}@divide_full_range
; IS__TUNIT_OPM-SAME: (i32 [[ARG:%.*]])
; IS__TUNIT_OPM-NEXT: [[CSRET:%.*]] = call i32 @less_than_65536(i32 [[ARG]]) [[ATTR2]], [[RNG5:!range !.*]]
; IS__TUNIT_OPM-NEXT: [[RET:%.*]] = call i1 @is_less_than_65536(i32 [[CSRET]])
; IS__TUNIT_OPM-NEXT: ret i1 [[RET]]
;
; IS__TUNIT_NPM: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT_NPM-LABEL: define {{[^@]+}}@divide_full_range
; IS__TUNIT_NPM-SAME: (i32 [[ARG:%.*]])
; IS__TUNIT_NPM-NEXT: [[CSRET:%.*]] = call i32 @less_than_65536(i32 [[ARG]]) [[ATTR1]], [[RNG6:!range !.*]]
; IS__TUNIT_NPM-NEXT: [[RET:%.*]] = call i1 @is_less_than_65536(i32 [[CSRET]])
; IS__TUNIT_NPM-NEXT: ret i1 [[RET]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@divide_full_range
; IS__CGSCC____-SAME: (i32 [[ARG:%.*]])
; IS__CGSCC____-NEXT: [[CSRET:%.*]] = call i32 @less_than_65536(i32 [[ARG]])
; IS__CGSCC____-NEXT: [[RET:%.*]] = call i1 @is_less_than_65536(i32 [[CSRET]])
; IS__CGSCC____-NEXT: ret i1 [[RET]]
;
%csret = call i32 @less_than_65536(i32 %arg)
%ret = call i1 @is_less_than_65536(i32 %csret)
ret i1 %ret
}
define internal i32 @cast_and_return(i1 %c) {
; IS__TUNIT____: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT____-LABEL: define {{[^@]+}}@cast_and_return
; IS__TUNIT____-SAME: (i1 [[C:%.*]])
; IS__TUNIT____-NEXT: [[RET:%.*]] = zext i1 [[C]] to i32
; IS__TUNIT____-NEXT: ret i32 [[RET]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@cast_and_return
; IS__CGSCC____-SAME: (i1 [[C:%.*]])
; IS__CGSCC____-NEXT: [[RET:%.*]] = zext i1 [[C]] to i32
; IS__CGSCC____-NEXT: ret i32 [[RET]]
;
%ret = zext i1 %c to i32
ret i32 %ret
}
define internal i1 @is_less_than_2(i32 %c) {
; IS__TUNIT____: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT____-LABEL: define {{[^@]+}}@is_less_than_2
; IS__TUNIT____-SAME: (i32 [[C:%.*]])
; IS__TUNIT____-NEXT: [[CMP:%.*]] = icmp slt i32 [[C]], 2
; IS__TUNIT____-NEXT: ret i1 [[CMP]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@is_less_than_2
; IS__CGSCC____-SAME: (i32 [[C:%.*]])
; IS__CGSCC____-NEXT: [[CMP:%.*]] = icmp slt i32 [[C]], 2
; IS__CGSCC____-NEXT: ret i1 [[CMP]]
;
%cmp = icmp slt i32 %c, 2
ret i1 %cmp
}
; FIXME: returned value can be simplified to i1 true
define i1 @check_casted_range(i1 %c) {
; IS__TUNIT_OPM: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT_OPM-LABEL: define {{[^@]+}}@cast_range
; IS__TUNIT_OPM-SAME: (i1 [[C:%.*]])
; IS__TUNIT_OPM-NEXT: [[CSRET:%.*]] = call i32 @cast_and_return(i1 [[C]]) [[ATTR2]], [[RNG3]]
; IS__TUNIT_OPM-NEXT: [[RET:%.*]] = call i1 @is_less_than_2(i32 [[CSRET]])
; IS__TUNIT_OPM-NEXT: ret i1 [[RET]]
;
; IS__TUNIT_NPM: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT_NPM-LABEL: define {{[^@]+}}@cast_range
; IS__TUNIT_NPM-SAME: (i1 [[C:%.*]])
; IS__TUNIT_NPM-NEXT: [[CSRET:%.*]] = call i32 @cast_and_return(i1 [[C]]) [[ATTR1]], [[RNG4]]
; IS__TUNIT_NPM-NEXT: [[RET:%.*]] = call i1 @is_less_than_2(i32 [[CSRET]])
; IS__TUNIT_NPM-NEXT: ret i1 [[RET]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@cast_range
; IS__CGSCC____-SAME: (i1 [[C:%.*]])
; IS__CGSCC____-NEXT: [[CSRET:%.*]] = call i32 @cast_and_return(i1 [[C]])
; IS__CGSCC____-NEXT: [[RET:%.*]] = call i1 @is_less_than_2(i32 [[CSRET]])
; IS__CGSCC____-NEXT: ret i1 [[RET]]
;
%csret = call i32 @cast_and_return(i1 %c)
%ret = call i1 @is_less_than_2(i32 %csret)
ret i1 %ret
}
define internal i32 @less_than_100(i32 %c) {
; IS__TUNIT____: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT____-LABEL: define {{[^@]+}}@less_than_100
; IS__TUNIT____-SAME: (i32 [[C:%.*]])
; IS__TUNIT____-NEXT: switch i32 [[C]], label [[OTHERWISE:%.*]] [
; IS__TUNIT____-NEXT: i32 0, label [[ONZERO:%.*]]
; IS__TUNIT____-NEXT: i32 1, label [[ONONE:%.*]]
; IS__TUNIT____-NEXT: i32 2, label [[ONTWO:%.*]]
; IS__TUNIT____-NEXT: i32 3, label [[ONTHREE:%.*]]
; IS__TUNIT____-NEXT: i32 4, label [[ONFOUR:%.*]]
; IS__TUNIT____-NEXT: i32 5, label [[ONFIVE:%.*]]
; IS__TUNIT____-NEXT: i32 6, label [[ONSIX:%.*]]
; IS__TUNIT____-NEXT: ]
; IS__TUNIT____: onzero:
; IS__TUNIT____-NEXT: ret i32 0
; IS__TUNIT____: onone:
; IS__TUNIT____-NEXT: ret i32 1
; IS__TUNIT____: ontwo:
; IS__TUNIT____-NEXT: ret i32 2
; IS__TUNIT____: onthree:
; IS__TUNIT____-NEXT: ret i32 3
; IS__TUNIT____: onfour:
; IS__TUNIT____-NEXT: ret i32 4
; IS__TUNIT____: onfive:
; IS__TUNIT____-NEXT: ret i32 5
; IS__TUNIT____: onsix:
; IS__TUNIT____-NEXT: ret i32 6
; IS__TUNIT____: otherwise:
; IS__TUNIT____-NEXT: ret i32 99
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@less_than_100
; IS__CGSCC____-SAME: (i32 [[C:%.*]])
; IS__CGSCC____-NEXT: switch i32 [[C]], label [[OTHERWISE:%.*]] [
; IS__CGSCC____-NEXT: i32 0, label [[ONZERO:%.*]]
; IS__CGSCC____-NEXT: i32 1, label [[ONONE:%.*]]
; IS__CGSCC____-NEXT: i32 2, label [[ONTWO:%.*]]
; IS__CGSCC____-NEXT: i32 3, label [[ONTHREE:%.*]]
; IS__CGSCC____-NEXT: i32 4, label [[ONFOUR:%.*]]
; IS__CGSCC____-NEXT: i32 5, label [[ONFIVE:%.*]]
; IS__CGSCC____-NEXT: i32 6, label [[ONSIX:%.*]]
; IS__CGSCC____-NEXT: ]
; IS__CGSCC____: onzero:
; IS__CGSCC____-NEXT: ret i32 0
; IS__CGSCC____: onone:
; IS__CGSCC____-NEXT: ret i32 1
; IS__CGSCC____: ontwo:
; IS__CGSCC____-NEXT: ret i32 2
; IS__CGSCC____: onthree:
; IS__CGSCC____-NEXT: ret i32 3
; IS__CGSCC____: onfour:
; IS__CGSCC____-NEXT: ret i32 4
; IS__CGSCC____: onfive:
; IS__CGSCC____-NEXT: ret i32 5
; IS__CGSCC____: onsix:
; IS__CGSCC____-NEXT: ret i32 6
; IS__CGSCC____: otherwise:
; IS__CGSCC____-NEXT: ret i32 99
;
switch i32 %c, label %otherwise [ i32 0, label %onzero
i32 1, label %onone
i32 2, label %ontwo
i32 3, label %onthree
i32 4, label %onfour
i32 5, label %onfive
i32 6, label %onsix]
onzero:
ret i32 0
onone:
ret i32 1
ontwo:
ret i32 2
onthree:
ret i32 3
onfour:
ret i32 4
onfive:
ret i32 5
onsix:
ret i32 6
otherwise:
ret i32 99
}
define internal i1 @is_less_than_100(i32 %c) {
; IS__TUNIT____: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT____-LABEL: define {{[^@]+}}@is_less_than_100
; IS__TUNIT____-SAME: (i32 [[C:%.*]])
; IS__TUNIT____-NEXT: [[CMP:%.*]] = icmp slt i32 [[C]], 100
; IS__TUNIT____-NEXT: ret i1 [[CMP]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@is_less_than_100
; IS__CGSCC____-SAME: (i32 [[C:%.*]])
; IS__CGSCC____-NEXT: [[CMP:%.*]] = icmp slt i32 [[C]], 100
; IS__CGSCC____-NEXT: ret i1 [[CMP]]
;
%cmp = icmp slt i32 %c, 100
ret i1 %cmp
}
; FIXME: returned value can be simplified to i1 true
define i1 @propagate_csret_to_float(i32 %c) {
; IS__TUNIT_OPM: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT_OPM-LABEL: define {{[^@]+}}@propagate_csret_to_float
; IS__TUNIT_OPM-SAME: (i32 [[C:%.*]])
; IS__TUNIT_OPM-NEXT: [[CSRET:%.*]] = call i32 @less_than_100(i32 [[C]]) [[ATTR2]], [[RNG6:!range !.*]]
; IS__TUNIT_OPM-NEXT: [[RET:%.*]] = call i1 @is_less_than_100(i32 [[CSRET]])
; IS__TUNIT_OPM-NEXT: ret i1 [[RET]]
;
; IS__TUNIT_NPM: Function Attrs: nofree nosync nounwind readnone willreturn
; IS__TUNIT_NPM-LABEL: define {{[^@]+}}@propagate_csret_to_float
; IS__TUNIT_NPM-SAME: (i32 [[C:%.*]])
; IS__TUNIT_NPM-NEXT: [[CSRET:%.*]] = call i32 @less_than_100(i32 [[C]]) [[ATTR1]], [[RNG7:!range !.*]]
; IS__TUNIT_NPM-NEXT: [[RET:%.*]] = call i1 @is_less_than_100(i32 [[CSRET]])
; IS__TUNIT_NPM-NEXT: ret i1 [[RET]]
;
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
; IS__CGSCC____-LABEL: define {{[^@]+}}@propagate_csret_to_float
; IS__CGSCC____-SAME: (i32 [[C:%.*]])
; IS__CGSCC____-NEXT: [[CSRET:%.*]] = call i32 @less_than_100(i32 [[C]])
; IS__CGSCC____-NEXT: [[RET:%.*]] = call i1 @is_less_than_100(i32 [[CSRET]])
; IS__CGSCC____-NEXT: ret i1 [[RET]]
;
%csret = call i32 @less_than_100(i32 %c)
%ret = call i1 @is_less_than_100(i32 %csret)
ret i1 %ret
}
!0 = !{i32 0, i32 10} !0 = !{i32 0, i32 10}
!1 = !{i32 10, i32 100} !1 = !{i32 10, i32 100}
; NOT_TUNIT____: !0 = !{i32 0, i32 10} ; NOT_TUNIT____: !0 = !{i32 0, i32 10}
; NOT_TUNIT____: !1 = !{i32 10, i32 100} ; NOT_TUNIT____: !1 = !{i32 10, i32 100}
; NOT_TUNIT____-NOT: !2 ; NOT_TUNIT____-NOT: !2
; IS__TUNIT_OPM: !0 = !{i32 0, i32 10} ; IS__TUNIT_OPM: !0 = !{i32 0, i32 10}
; IS__TUNIT_OPM: !1 = !{i32 10, i32 100} ; IS__TUNIT_OPM: !1 = !{i32 10, i32 100}
; IS__TUNIT_OPM: !2 = !{i32 200, i32 1091} ; IS__TUNIT_OPM: !2 = !{i32 200, i32 1091}
; IS__TUNIT_OPM: !3 = !{i32 0, i32 2} ; IS__TUNIT_OPM: !3 = !{i32 0, i32 2}
; IS__TUNIT_OPM: !4 = !{i32 1, i32 3} ; IS__TUNIT_OPM: !4 = !{i32 1, i32 3}
; IS__TUNIT_OPM-NOT: !5 ; IS__TUNIT_OPM: !5 = !{i32 0, i32 65536}
; IS__TUNIT_OPM: !6 = !{i32 0, i32 100}
; IS__TUNIT_OPM-NOT: !7
; IS__TUNIT_NPM: !0 = !{i32 0, i32 10} ; IS__TUNIT_NPM: !0 = !{i32 0, i32 10}
; IS__TUNIT_NPM: !1 = !{i32 10, i32 100} ; IS__TUNIT_NPM: !1 = !{i32 10, i32 100}
; IS__TUNIT_NPM: !2 = !{i32 200, i32 1091} ; IS__TUNIT_NPM: !2 = !{i32 200, i32 1091}
; IS__TUNIT_NPM: !3 = !{i32 1, i32 -2147483648} ; IS__TUNIT_NPM: !3 = !{i32 1, i32 -2147483648}
; IS__TUNIT_NPM: !4 = !{i32 0, i32 2} ; IS__TUNIT_NPM: !4 = !{i32 0, i32 2}
; IS__TUNIT_NPM: !5 = !{i32 1, i32 3} ; IS__TUNIT_NPM: !5 = !{i32 1, i32 3}
; IS__TUNIT_NPM-NOT: !6 ; IS__TUNIT_NPM: !6 = !{i32 0, i32 65536}
; IS__TUNIT_NPM: !7 = !{i32 0, i32 100}
; IS__TUNIT_NPM-NOT: !8
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

What is the difference to less_than_100_1?

jdoerfert: What is the difference to `less_than_100_1`?
okuraAuthorUnsubmitted
Not Done
ReplyInline Actions

(less_than_100 | is_less_than_100) _1 and _2 are the same (respectively). I duplicate them because I want to split propagate_range1 and propagate_range2 completely.
When I handle CallBase in AAValueConstantRange::initialize, the value will be simplified in the former case and will not in the latter case. However, If we use the same less_than_100 and is_less_than_100 in both tests, the value will be simplified in both cases.

okura: (`less_than_100` | `is_less_than_100`) _1 and _2 are the same (respectively). I duplicate them…
jdoerfertUnsubmitted
Not Done
ReplyInline Actions

makes sense.

jdoerfert: makes sense.