This is an archive of the discontinued LLVM Phabricator instance.

[Attributor][NFC] Add tests to range.ll
ClosedPublic

Authored by okura on Aug 17 2020, 9:57 PM.

Diff Detail

Event Timeline

okura created this revision.Aug 17 2020, 9:57 PM
Herald added a reviewer: homerdin. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
okura requested review of this revision.Aug 17 2020, 9:57 PM
okura updated this revision to Diff 286214.Aug 18 2020, 1:30 AM
  • add more tests
jdoerfert added inline comments.Aug 18 2020, 8:28 AM
llvm/test/Transforms/Attributor/range.ll
1766

What is the difference to less_than_100_1?

okura added inline comments.Aug 18 2020, 11:32 AM
llvm/test/Transforms/Attributor/range.ll
1766

(less_than_100 | is_less_than_100) _1 and _2 are the same (respectively). I duplicate them because I want to split propagate_range1 and propagate_range2 completely.
When I handle CallBase in AAValueConstantRange::initialize, the value will be simplified in the former case and will not in the latter case. However, If we use the same less_than_100 and is_less_than_100 in both tests, the value will be simplified in both cases.

jdoerfert accepted this revision.Aug 18 2020, 12:22 PM

LGTM.

llvm/test/Transforms/Attributor/range.ll
1766

makes sense.

This revision is now accepted and ready to land.Aug 18 2020, 12:22 PM
This revision was automatically updated to reflect the committed changes.