This is an archive of the discontinued LLVM Phabricator instance.

[lldb] avoid assert in threadsanitizer tests on linux
AbandonedPublic

Authored by llunak on Aug 17 2020, 2:02 PM.

Details

Summary

The tsan tests are unsupported on linux, but they assert in Thread::GetStopDescriptionRaw() because of empty stop reason description. And it is empty because InstrumentationRuntimeTSan::NotifyBreakpointHit() fails to get report from InstrumentationRuntimeTSan::RetrieveReportData(), which is possibly(?) the reason why this is unsupported on linux. Add a dummy stop reason description for this case, which changes the test result from failing to unsupported.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

llunak created this revision.Aug 17 2020, 2:02 PM
llunak requested review of this revision.Aug 17 2020, 2:02 PM

LGTM, but Kuba should ok this one since he does more ASAN and TSAN stuff.

kubamracek accepted this revision.Aug 30 2020, 8:52 PM

Looks good for get rid of the test failure.

(Although it would we good to actually figure out why RetrieveReportData doesn't work.)

This revision is now accepted and ready to land.Aug 30 2020, 8:52 PM
clayborg accepted this revision.Aug 31 2020, 3:22 PM
llunak abandoned this revision.Sep 4 2020, 12:38 AM

Closing, I forgot to add the "Differential Revision:" line, but D86593 landed sooner anyway.

Sorry, I totally didn't see this patch (I also only added Fred as a reviewer as he added the assert, so there weren't even any shared reviewers who could have pointed this out).