Page MenuHomePhabricator

[lldb] Don't crash when LLDB can't extract the tsan report
ClosedPublic

Authored by teemperor on Aug 26 2020, 1:00 AM.

Details

Summary

Right now all tsan tests are crashing on Linux. The tests were already marked as expected failures, but since commit
20ce8affce85d added an assert that every StopInfo needs a non-empty stop description the
tests actually started crash (which is even with an expectedFailure a failed test).

The reason for that is that we never had any stop description when hitting tsan errors on Linux. Before the assert
that just made the test fail, but now the empty description is hitting the assert. This patch just adds a
generic stop description mentioning tsan to prevent that we hit that assert on platforms where we don't support
extracting the tsan report.

Diff Detail

Event Timeline

teemperor requested review of this revision.Aug 26 2020, 1:00 AM
teemperor created this revision.

The assert I'm mentioning is the one added in the commit:

assert((!raw_stop_description.empty() ||
        stop_info_sp->GetStopReason() == eStopReasonNone) &&
       "StopInfo returned an empty description.");
friss accepted this revision.Aug 26 2020, 8:24 AM

LGTM

This revision is now accepted and ready to land.Aug 26 2020, 8:24 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 31 2020, 2:13 AM