User Details
- User Since
- Dec 17 2017, 4:06 AM (161 w, 1 d)
Oct 6 2020
LGTM, although I'm not sure if me saying that is enough. I'll commit this in few days if nobody says anything else.
Oct 1 2020
I tried pretty hard to get a small repro for these failures, but couldn't.
Sep 22 2020
Sep 19 2020
Ping.
Sep 4 2020
Closing, I forgot to add the "Differential Revision:" line, but D86593 landed sooner anyway.
Sep 3 2020
Ping.
Aug 29 2020
Funny coincidence, the ctor has been broken for 5 years and that commit introducing my problem has been there for a year. Ok, closing, thank you for your help.
No, everything's fine :). See the updated patch. The UnwindPlan object already enters x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite() with the lazybool uninitialized and fixing that fixes everything:
And it indeed was suspicious. 3fd917d8860e9bdcabc14c536da4377307906be0 didn't update the UnwindPlan copy ctor to copy the field.
Aug 26 2020
...
The other way is from the Platform CalculateTrapHandlerSymbolNames method. PlatformLinux sets these to
...
is one of these wrong?
Aug 25 2020
Aug 24 2020
Updated to not use environment variable.
Aug 23 2020
Aug 18 2020
Aug 17 2020
Ping.
Aug 5 2020
Change also SetBackground() calls.
Use SteamString.
I personally don't particularly care where the tests are, I just wanted all the gui tests to be together to make it simpler to run them all.
Aug 4 2020
Updated according to comments.
Aug 3 2020
Handle properly also the "<<< Thread 1: breakpoint 1.1" marker.
Removed use of curses python module, lldbexpect hardcodes TERM=vt100, so the escape sequence should be actually hardcoded too. The previous version didn't work e.g. in Linux console.
Aug 2 2020
The DWARF in the source file appears to be broken, the test fails for me on openSUSE 15.2 x86_64, with errors about DIE references outside of its CU. It fails even if I try to manually compile and debug the file, with Clang git or 9, GCC 7.5 or 9, LLDB git or 9, GDB 9.2.
Jul 31 2020
Adjusted according to the comments.
Jul 30 2020
Jul 29 2020
Updated for current git.
Updated for current git, and clang-format-ed.
Updated for current git, and clang-format-ed.
My usual experience with Clang submissions is that I have to be really persistent to get a reaction, let alone an approval, so I assumed it was the same here and I didn't feel like pushing this that much. I'll update the patches to match current git and have a look at the review that still has questions.
Jul 22 2020
Jul 21 2020
Updated driver test to just create a dummy file for PCH.
@llunak Would you be able to test this on anything you've got?
Jul 18 2020
Used OptInFFlag and adapted to changes in D83716.
Moved driver test under test/Driver/.