Page MenuHomePhabricator

llunak (Luboš Luňák)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 17 2017, 4:06 AM (113 w, 3 d)

Recent Activity

Today

llunak created D74846: fix -fcodegen-modules code when used with PCH (PR44958).
Wed, Feb 19, 9:21 AM · Restricted Project

Yesterday

llunak added a comment to D73846: make sure to not warn about unused macros from -D.

Ping..

Tue, Feb 18, 12:42 AM · Restricted Project
llunak added a comment to D69585: PerformPendingInstatiations() already in the PCH.

Ping.....

Tue, Feb 18, 12:42 AM · Restricted Project

Sun, Feb 16

llunak updated subscribers of D73846: make sure to not warn about unused macros from -D.
Sun, Feb 16, 1:45 AM · Restricted Project

Wed, Feb 12

llunak added a comment to D73852: [clang] detect switch fallthrough marked by a comment (PR43465).

This patch also omitted cfe-commits lists.

Wed, Feb 12, 7:55 AM · Restricted Project

Sun, Feb 9

llunak added a comment to D69585: PerformPendingInstatiations() already in the PCH.

Ping again. Is there still something more to do here?

Sun, Feb 9, 3:36 AM · Restricted Project
llunak added a comment to D73846: make sure to not warn about unused macros from -D.

Ping.

Sun, Feb 9, 3:36 AM · Restricted Project

Mon, Feb 3

llunak committed rG398b4ed87d48: [clang] detect switch fallthrough marked by a comment (PR43465) (authored by llunak).
[clang] detect switch fallthrough marked by a comment (PR43465)
Mon, Feb 3, 10:42 AM
llunak closed D73852: [clang] detect switch fallthrough marked by a comment (PR43465).
Mon, Feb 3, 10:41 AM · Restricted Project
llunak updated the diff for D73852: [clang] detect switch fallthrough marked by a comment (PR43465).
Mon, Feb 3, 9:09 AM · Restricted Project
llunak added inline comments to D73852: [clang] detect switch fallthrough marked by a comment (PR43465).
Mon, Feb 3, 9:09 AM · Restricted Project
llunak added inline comments to D73852: [clang] detect switch fallthrough marked by a comment (PR43465).
Mon, Feb 3, 7:43 AM · Restricted Project
llunak updated the diff for D73852: [clang] detect switch fallthrough marked by a comment (PR43465).

Updated according to comments.

Mon, Feb 3, 7:43 AM · Restricted Project

Sun, Feb 2

llunak updated the diff for D73852: [clang] detect switch fallthrough marked by a comment (PR43465).

Fix possible crash, cache regex.

Sun, Feb 2, 11:46 AM · Restricted Project
llunak created D73852: [clang] detect switch fallthrough marked by a comment (PR43465).
Sun, Feb 2, 11:20 AM · Restricted Project
llunak created D73846: make sure to not warn about unused macros from -D.
Sun, Feb 2, 3:25 AM · Restricted Project

Sat, Feb 1

llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

(Removed unintended debug output in tests.)

Sat, Feb 1, 12:23 AM · Restricted Project

Fri, Jan 31

llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

I've found a corner case, as shown by clang/test/PCH/delayed-pch-instantiate.cpp, where it really is necessary to perform an instantiation in the TU. I've updated the patch to detect this and repeat these instantiations the way they would be without the patch.

Fri, Jan 31, 11:58 AM · Restricted Project

Tue, Jan 28

llunak added inline comments to D69585: PerformPendingInstatiations() already in the PCH.
Tue, Jan 28, 1:38 AM · Restricted Project

Jan 18 2020

llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

Handled all tests which failed because the change moved templates in -emit-llvm output.
Added a test for specialization of a template instantiated in a PCH.

Jan 18 2020, 11:00 AM · Restricted Project
llunak added inline comments to D69585: PerformPendingInstatiations() already in the PCH.
Jan 18 2020, 10:51 AM · Restricted Project

Jan 16 2020

llunak added a comment to D69585: PerformPendingInstatiations() already in the PCH.

I thought you were going to add an option or a flag to control the behavior? If so, just provide an option in tests to avoid triggering of the new behavior (except for declare_target... test and those 2 you modified already) and that's it.

Jan 16 2020, 2:53 PM · Restricted Project
llunak added a comment to D72759: OpenMP breaks with PerformPendingInstatiations() already in the PCH.

Could you please still provide input in https://reviews.llvm.org/D69585? The patch still fails in 21 OpenMP tests simply because of compiler output getting reordered, which seems to require extensive reorganizing of the tests, and I don't want to do extensive (and tedious) changes there without your input.

Jan 16 2020, 6:42 AM · Restricted Project
llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

What is the error?

Jan 16 2020, 6:38 AM · Restricted Project
llunak abandoned D72759: OpenMP breaks with PerformPendingInstatiations() already in the PCH.
Jan 16 2020, 4:56 AM · Restricted Project

Jan 15 2020

llunak added a comment to D72759: OpenMP breaks with PerformPendingInstatiations() already in the PCH.

Fails in what way?

Jan 15 2020, 8:12 AM · Restricted Project
llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

In order to simplify this, I've updated the patch to remove any reference to OpenMP and I've moved that part to https://reviews.llvm.org/D72759 .

Jan 15 2020, 4:29 AM · Restricted Project
llunak created D72759: OpenMP breaks with PerformPendingInstatiations() already in the PCH.
Jan 15 2020, 4:10 AM · Restricted Project

Jan 14 2020

llunak committed rGcbc9d22e49b4: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak).
make -fmodules-codegen and -fmodules-debuginfo work also with PCHs
Jan 14 2020, 3:05 PM
llunak closed D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers.
Jan 14 2020, 3:05 PM · Restricted Project
llunak committed rGb5b2cf7af47f: fix recent -fmodules-codegen fix test (authored by llunak).
fix recent -fmodules-codegen fix test
Jan 14 2020, 2:55 PM
llunak committed rG729530f68fe1: -fmodules-codegen should not emit extern templates (authored by llunak).
-fmodules-codegen should not emit extern templates
Jan 14 2020, 2:46 PM
llunak closed D69779: -fmodules-codegen should not emit extern templates.
Jan 14 2020, 2:45 PM · Restricted Project
llunak updated the diff for D69779: -fmodules-codegen should not emit extern templates.

This version uses a module based on the code posted above.

Jan 14 2020, 1:38 PM · Restricted Project
llunak updated the diff for D69779: -fmodules-codegen should not emit extern templates.

I've updated the test as requested.

Jan 14 2020, 1:28 PM · Restricted Project
llunak added a comment to D69585: PerformPendingInstatiations() already in the PCH.
In D69585#1818205, @rnk wrote:

I'm interested in making clang do this, but I think this needs significantly more work until this is ready to land. It needs in-tree tests.

Jan 14 2020, 2:37 AM · Restricted Project

Jan 13 2020

llunak updated the summary of D69585: PerformPendingInstatiations() already in the PCH.
Jan 13 2020, 2:02 PM · Restricted Project
llunak added a comment to D69779: -fmodules-codegen should not emit extern templates.

Do you need some more information about the patch? It'd be nice if this could make it into 10.0.

Jan 13 2020, 2:02 PM · Restricted Project

Jan 8 2020

llunak added a comment to D69585: PerformPendingInstatiations() already in the PCH.

Ping.

Jan 8 2020, 10:59 AM · Restricted Project

Jan 7 2020

llunak added a comment to D69779: -fmodules-codegen should not emit extern templates.

Ah, if I mark the standalone function template 'inline' (the implicit linkage of member functions) then I get the same failure for both. Haven't tested whether the fix is the same fix for both yet.

Jan 7 2020, 11:21 AM · Restricted Project

Dec 20 2019

llunak abandoned D69050: make BumpPtrAllocator's slab size growth speed configurable.

Closing, handled in D71654.

Dec 20 2019, 5:20 AM · Restricted Project
llunak accepted D71699: [lldb] Increase the rate at which ConstString's memory allocator scales the memory chunks it allocates.

I'm back at using gdb for the time being, so I'd have to build code with debuginfo suitable for lldb, which would take some time. But given that this is more or less the same as I did before, I don't see why this shouldn't work similarly. Thank you for getting these changes in.

Dec 20 2019, 5:19 AM · Restricted Project

Dec 11 2019

llunak added a comment to D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers.

I guess one aspect is that -building-pch-with-obj seems like it duplicates the fmodules-codegen concept (both basically are a flag passed during pcm/pch build time that says "I promise to build an object file from this pcm/pch, so rely on that assumption when building other things that depend on the pcm/pch) - if I'd noticed the -building-pch-with-obj going in I would've made the point then.

Dec 11 2019, 12:49 AM · Restricted Project

Dec 6 2019

llunak added a comment to D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers.

It's a bit weird for this to be controlled by a -fmodules flag, but it's only a -cc1 flag, so I'm OK with that; we can rename it if/when we expose it from the driver.

Dec 6 2019, 2:00 AM · Restricted Project

Dec 5 2019

llunak added a comment to D69779: -fmodules-codegen should not emit extern templates.

Ping.

Dec 5 2019, 12:07 PM · Restricted Project
llunak added a comment to D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers.

Ping.

Dec 5 2019, 12:07 PM · Restricted Project
llunak added a comment to D69585: PerformPendingInstatiations() already in the PCH.

Ping.

Dec 5 2019, 12:07 PM · Restricted Project

Nov 17 2019

llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

It turns out that this patch may introduce unwanted changes, specifically it can cause err_specialization_after_instantiation if the specialization is done in a source file but needed already by code in the PCH. But this seems to be rare (I've encountered it only after building the Skia library with put-everything-in-the-PCH), is easy to avoid (PCHs often need little tweaks anyway) and the performance gain is very much worth it.

Nov 17 2019, 11:24 AM · Restricted Project

Nov 7 2019

llunak added a comment to D68909: change shortcut for 'step out' from 'o' to 'f'.
In D68909#1736931, @kwk wrote:

Are there no tests for this code?

Nov 7 2019, 7:04 AM · Restricted Project

Nov 6 2019

llunak added reviewers for D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers: rsmith, hans.
Nov 6 2019, 12:51 AM · Restricted Project

Nov 3 2019

llunak created D69779: -fmodules-codegen should not emit extern templates.
Nov 3 2019, 1:42 PM · Restricted Project
llunak created D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers.
Nov 3 2019, 1:33 PM · Restricted Project

Nov 2 2019

llunak committed rG4f2104c5adbc: make -ftime-trace also trace time spent creating debug info (authored by llunak).
make -ftime-trace also trace time spent creating debug info
Nov 2 2019, 10:13 AM
llunak closed D69750: make -ftime-trace also trace time spent creating debug info.
Nov 2 2019, 10:13 AM · Restricted Project
llunak created D69750: make -ftime-trace also trace time spent creating debug info.
Nov 2 2019, 8:48 AM · Restricted Project
llunak updated the diff for D69585: PerformPendingInstatiations() already in the PCH.

Let's go a different route. This patch fully passes all tests and so should be ready to be committed.

Nov 2 2019, 4:40 AM · Restricted Project
llunak added a comment to D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Can you please ACK also the other patches linked above that this one depends on? Or can I take the discussion here as being enough?

Nov 2 2019, 2:29 AM · Restricted Project
llunak committed rG79d8996d73f3: python path should be platform-dependent (authored by llunak).
python path should be platform-dependent
Nov 2 2019, 2:25 AM
llunak closed D68910: python path should be platform-dependent.
Nov 2 2019, 2:24 AM · Restricted Project
llunak added a comment to D69050: make BumpPtrAllocator's slab size growth speed configurable.

Ping?

Nov 2 2019, 2:24 AM · Restricted Project

Oct 29 2019

llunak abandoned D41332: LSAN_OPTIONS=log_path=xxx is ignored.

Handled by https://reviews.llvm.org/D42303 .

Oct 29 2019, 2:03 PM · Restricted Project, Restricted Project
llunak abandoned D64284: (WIP) share template instantiations from PCH in one .o if -building-pch-with-obj.

Due to some technical problems with this approach and lack of feedback, I'm scratching this one. A new approach is at https://reviews.llvm.org/D69585 .

Oct 29 2019, 2:00 PM · Restricted Project
llunak created D69585: PerformPendingInstatiations() already in the PCH.
Oct 29 2019, 1:58 PM · Restricted Project

Oct 26 2019

llunak committed rG9231e443445f: fix lldb build with -DLLVM_ENABLE_MODULES=On (missing #include) (authored by llunak).
fix lldb build with -DLLVM_ENABLE_MODULES=On (missing #include)
Oct 26 2019, 6:44 AM

Oct 16 2019

llunak added a comment to D68549: make ConstString allocate memory in non-tiny chunks.

We could also just let the allocator take a parameter so that is increases the growth size to do it every Nth slab (N=1 for us) and set a slightly larger starting size.

Oct 16 2019, 9:41 AM · Restricted Project
llunak created D69050: make BumpPtrAllocator's slab size growth speed configurable.
Oct 16 2019, 9:32 AM · Restricted Project
llunak added a comment to D68549: make ConstString allocate memory in non-tiny chunks.

Thinking more about this, maybe this is really not the right place and the change should be done in BumpPtrAllocator? To me it seems rather unreasonable that it would double the allocation size only after 128 allocations. Surely by the time it has already allocated 128*4096=0.5MiB memory it could have decided to raise the allocation size much sooner?

Oct 16 2019, 4:28 AM · Restricted Project
llunak added a comment to D68549: make ConstString allocate memory in non-tiny chunks.

Oh, I somehow completely missed the fact that there are 256 of those :-/. In that case my numbers are way too much. Can you easily benchmark with different numbers? I think something like 131072 for BumpPtrAllocator (to still be large enough for the mmap threshold) could be reasonable, the size for StringPool can go down to 256 or maybe can be simply dropped.

Oct 16 2019, 1:57 AM · Restricted Project
llunak added a comment to D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Looks good!

Oct 16 2019, 12:47 AM · Restricted Project
llunak added a comment to D68910: python path should be platform-dependent.
In D68910#1710147, @hhb wrote:

This is fine for me. Actually it doesn't make any difference for all platforms I tried... Out of curiosity, is it possible to share the implementation of get_python_lib() in openSUSE? Thanks.

Oct 16 2019, 12:35 AM · Restricted Project

Oct 15 2019

llunak updated the diff for D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Adjusted the testcase.

Oct 15 2019, 1:00 PM · Restricted Project
llunak updated the diff for D68910: python path should be platform-dependent.

How about this one?

Oct 15 2019, 12:41 PM · Restricted Project
llunak added a comment to D68910: python path should be platform-dependent.
In D68910#1709832, @hhb wrote:

Can you sync to the latest code and try again? Your problem is likely to be fixed in a previous change...

Oct 15 2019, 12:41 PM · Restricted Project
llunak updated the diff for D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Removed the explicit test timeout.

Oct 15 2019, 10:11 AM · Restricted Project
llunak added inline comments to D68541: Implement 'up' and 'down' shortcuts in lldb gui.
Oct 15 2019, 10:11 AM · Restricted Project

Oct 12 2019

llunak updated the diff for D68910: python path should be platform-dependent.

Updated misleading description.

Oct 12 2019, 5:44 AM · Restricted Project
llunak created D68910: python path should be platform-dependent.
Oct 12 2019, 4:50 AM · Restricted Project
llunak updated the diff for D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Added a unittest.

Oct 12 2019, 4:50 AM · Restricted Project
llunak created D68909: change shortcut for 'step out' from 'o' to 'f'.
Oct 12 2019, 4:43 AM · Restricted Project
llunak created D68908: remove somewhat dangerous 'd'(etach) and 'k'(ill) shortcuts.
Oct 12 2019, 4:41 AM · Restricted Project

Oct 11 2019

llunak committed rGe2ca7cb504a8: make ConstString allocate memory in non-tiny chunks (authored by llunak).
make ConstString allocate memory in non-tiny chunks
Oct 11 2019, 12:36 PM
llunak closed D68549: make ConstString allocate memory in non-tiny chunks.
Oct 11 2019, 12:36 PM · Restricted Project
llunak committed rL374583: make ConstString allocate memory in non-tiny chunks.
make ConstString allocate memory in non-tiny chunks
Oct 11 2019, 12:33 PM

Oct 8 2019

llunak added a comment to D68541: Implement 'up' and 'down' shortcuts in lldb gui.

It would be fine to remove the 'd' shortcut for detach and resume if we need to by moving this functionality up into the menu bar. Right now the Process menu has "Detach" only, so it might be good to first change the "Process" menu to have "Detach" or "Detach suspended". I agree that accidentally hitting 'd' would be bad.

Oct 8 2019, 1:56 PM · Restricted Project
llunak added a comment to D68541: Implement 'up' and 'down' shortcuts in lldb gui.

Would it be possible to add a test for this? Maybe you can extend TestGuiBasic.py.

Oct 8 2019, 12:31 PM · Restricted Project
llunak added a comment to D68549: make ConstString allocate memory in non-tiny chunks.

This makes sense to me. We may need to make this configurable for low-memory hosts at some point.

Oct 8 2019, 12:22 PM · Restricted Project

Oct 6 2019

llunak updated the diff for D68549: make ConstString allocate memory in non-tiny chunks.

Increased default number of buckets for StringMap too.

Oct 6 2019, 6:42 AM · Restricted Project

Oct 5 2019

llunak created D68549: make ConstString allocate memory in non-tiny chunks.
Oct 5 2019, 7:47 PM · Restricted Project
llunak created D68541: Implement 'up' and 'down' shortcuts in lldb gui.
Oct 5 2019, 12:24 PM · Restricted Project

Sep 18 2019

llunak committed rG3425a8967676: fix build, adjust test also for Windows path separator (authored by llunak).
fix build, adjust test also for Windows path separator
Sep 18 2019, 2:47 PM
llunak committed rL372263: fix build, adjust test also for Windows path separator.
fix build, adjust test also for Windows path separator
Sep 18 2019, 2:46 PM
llunak committed rG1e9c1d2b7bfc: actually also compile output in tests for -frewrite-includes (authored by llunak).
actually also compile output in tests for -frewrite-includes
Sep 18 2019, 12:18 PM
llunak committed rL372250: actually also compile output in tests for -frewrite-includes.
actually also compile output in tests for -frewrite-includes
Sep 18 2019, 12:18 PM
llunak closed D63979: actually also compile output in tests for -frewrite-includes.
Sep 18 2019, 12:18 PM · Restricted Project, Restricted Project
llunak committed rG533434fc728a: make -frewrite-includes also rewrite conditions in #if/#elif (authored by llunak).
make -frewrite-includes also rewrite conditions in #if/#elif
Sep 18 2019, 12:09 PM
llunak committed rL372248: make -frewrite-includes also rewrite conditions in #if/#elif.
make -frewrite-includes also rewrite conditions in #if/#elif
Sep 18 2019, 12:08 PM
llunak closed D63508: make -frewrite-includes also rewrite conditions in #if/#elif.
Sep 18 2019, 12:08 PM · Restricted Project, Restricted Project

Sep 17 2019

llunak added a comment to D63508: make -frewrite-includes also rewrite conditions in #if/#elif.

So, this will make -frewrite-includes do more work, to ensure that it not only covers the "top level" #include or __has_include case, but also __has_include in one or more levels of macros?

Does that effectively means it needs to do full preprocessing?

Sep 17 2019, 1:57 AM · Restricted Project, Restricted Project

Sep 16 2019

llunak added a comment to D63508: make -frewrite-includes also rewrite conditions in #if/#elif.

I've noticed that the Developer Policy says that it's actually allowed to commit patches without approval for parts "that you have contributed or maintain". Given that I'm the author of -rewrite-includes I take it that it's ok if I commit this if there are no further comments.

Sep 16 2019, 1:05 PM · Restricted Project, Restricted Project
llunak updated the diff for D63508: make -frewrite-includes also rewrite conditions in #if/#elif.
  • updated to apply to current trunk
  • changed misleading condition in a test
Sep 16 2019, 12:58 PM · Restricted Project, Restricted Project