This is an archive of the discontinued LLVM Phabricator instance.

Differential D86091

[cmake] Fix build of attribute plugin example on Windows
ClosedPublic

Authored by krisb on Aug 17 2020, 9:57 AM.

Details

Reviewers
john.brawn
Commits
rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows
Summary

Seems '${cmake_2_8_12_PRIVATE}' was removed long time ago, so it should
be just PRIVATE keyword here.

Diff Detail

Event Timeline

krisb created this revision.Aug 17 2020, 9:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 17 2020, 9:57 AM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
krisb requested review of this revision.Aug 17 2020, 9:57 AM
Harbormaster completed remote builds in B68625: Diff 286056.Aug 17 2020, 10:43 AM
john.brawn accepted this revision.Sep 2 2020, 9:47 AM

LGTM (looks like the other example plugins just use PRIVATE as well).

This revision is now accepted and ready to land.Sep 2 2020, 9:47 AM
This revision was landed with ongoing or failed builds.Sep 7 2020, 1:05 AM
Closed by commit rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows (authored by krisb). · Explain Why
This revision was automatically updated to reflect the committed changes.
krisb added a commit: rG04ea680a8ccc: [cmake] Fix build of attribute plugin example on Windows.
mati865 added subscribers: hans, mati865.Sep 26 2020, 11:28 AM

@hans sorry for not spotting it earlier but is it possible to still backport it to LLVM 11?
It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 repository.

hans added a comment.Sep 28 2020, 3:43 AM
In D86091#2296576, @mati865 wrote:

@hans sorry for not spotting it earlier but is it possible to still backport it to LLVM 11?
It's totally OK if it's too late. I can easily keep it as a patch in MSYS2 repository.

I'd prefer not to. It can probably wait until 11.0.1.

Revision Contents

PathSize
clang/
examples/
Attribute/
2 lines

Diff 290197

clang/examples/Attribute/CMakeLists.txt

add_llvm_library(Attribute MODULE Attribute.cpp PLUGIN_TOOL clang) add_llvm_library(Attribute MODULE Attribute.cpp PLUGIN_TOOL clang)
if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN)) if(LLVM_ENABLE_PLUGINS AND (WIN32 OR CYGWIN))
target_link_libraries(Attribute ${cmake_2_8_12_PRIVATE} target_link_libraries(Attribute PRIVATE
clangAST clangAST
clangBasic clangBasic
clangFrontend clangFrontend
clangLex clangLex
LLVMSupport LLVMSupport
) )
endif() endif()