This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Remove SIFixupVectorISel pass
ClosedPublic

Authored by arsenm on Aug 13 2020, 1:48 PM.

Details

Summary

This was only used for matching the saddr addressing mode of global
instructions, but this was not implemented correctly. The instruction
definitions aren't even correct, and are defined as using a 64-bit
VGPR component. Eliminate this pass to enable correcting the
instruction definitions. A new matching implementation can work in
GlobalISel or relying on DAG divergence information for the base
address.

Diff Detail

Event Timeline

arsenm created this revision.Aug 13 2020, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 13 2020, 1:48 PM
arsenm requested review of this revision.Aug 13 2020, 1:48 PM
rampitec accepted this revision.Aug 13 2020, 1:52 PM
This revision is now accepted and ready to land.Aug 13 2020, 1:52 PM
llvm/test/CodeGen/AMDGPU/ds_write2st64.ll