This is an archive of the discontinued LLVM Phabricator instance.

clang/lib/Frontend/InitPreprocessor.cpp
1127 ↗	(On Diff #285464)	This should also test `LangOpts.CplusPlus` so it's never defined in C compilation. I don't know what precedents there are to follow for how to choose the exact name here. Having something like `__CXX_ABI_` be a prefix for all such things seems wise.

mcgrathr added inline comments.Aug 13 2020, 2:03 PM

clang/lib/Frontend/InitPreprocessor.cpp
1127 ↗	(On Diff #285464)	That does seem like a very good fit here, and really easy to use with just one line in Features.def AFAICT. Maybe `__has_feature(cxx_abi_relative_vtable)` and in future add more `cxx_abi_foo` ones?

leonardchan updated this revision to Diff 285506.Aug 13 2020, 3:06 PM

leonardchan retitled this revision from [clang] Add __RELATIVE_CXX_ABI_VTABLES predefine macro to [clang][feature] Add cxx_abi_relative_vtable feature.

leonardchan edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B68341: Diff 285506.Aug 13 2020, 3:51 PM

LGTM but I'm not sure who should sign off on new __has_feature symbols.

This revision is now accepted and ready to land.Aug 14 2020, 1:05 PM

CC @aaron.ballman who committed Features.def for signing off or knowing someone who can sign off.

*ping* @aaron.ballman. Would you be able to sign off on this? Otherwise, I'll probably commit this in the next few days.

This LGTM, but I agree someone should sign off on whether __has_feature is the right approach here. @aaron.ballman ?

Closed by commit rG64c0792946b7: [clang][feature] Add cxx_abi_relative_vtable feature (authored by leonardchan). · Explain WhyOct 8 2020, 10:31 AM

This revision was automatically updated to reflect the committed changes.

leonardchan added a commit: rG64c0792946b7: [clang][feature] Add cxx_abi_relative_vtable feature.

Revision Contents

Path

Size

clang/

include/

clang/

Basic/

Features.def

2 lines

test/

Lexer/

has_feature_cxx_abi_relative_vtable.cpp

13 lines

Diff 297011

clang/include/clang/Basic/Features.def

	Show First 20 Lines • Show All 250 Lines • ▼ Show 20 Lines
	// Miscellaneous language extensions			// Miscellaneous language extensions
	EXTENSION(overloadable_unmarked, true)			EXTENSION(overloadable_unmarked, true)
	EXTENSION(pragma_clang_attribute_namespaces, true)			EXTENSION(pragma_clang_attribute_namespaces, true)
	EXTENSION(pragma_clang_attribute_external_declaration, true)			EXTENSION(pragma_clang_attribute_external_declaration, true)
	EXTENSION(gnu_asm, LangOpts.GNUAsm)			EXTENSION(gnu_asm, LangOpts.GNUAsm)
	EXTENSION(gnu_asm_goto_with_outputs, LangOpts.GNUAsm)			EXTENSION(gnu_asm_goto_with_outputs, LangOpts.GNUAsm)
	EXTENSION(matrix_types, LangOpts.MatrixTypes)			EXTENSION(matrix_types, LangOpts.MatrixTypes)

				FEATURE(cxx_abi_relative_vtable, LangOpts.CPlusPlus && LangOpts.RelativeCXXABIVTables)

	#undef EXTENSION			#undef EXTENSION
	#undef FEATURE			#undef FEATURE

clang/test/Lexer/has_feature_cxx_abi_relative_vtable.cpp

This file was added.

				// RUN: %clang_cc1 -E %s -triple x86_64-linux-gnu -x c++ -o - \| FileCheck %s --check-prefix=NO-RELATIVE-VTABLE
				// RUN: %clang_cc1 -E %s -triple x86_64-linux-gnu -x c++ -fexperimental-relative-c++-abi-vtables -o - \| FileCheck %s --check-prefix=RELATIVE-VTABLE
				// RUN: %clang_cc1 -E %s -triple x86_64-linux-gnu -x c++ -fno-experimental-relative-c++-abi-vtables -o - \| FileCheck %s --check-prefix=NO-RELATIVE-VTABLE
				// RUN: %clang_cc1 -E %s -triple x86_64-linux-gnu -x c -fexperimental-relative-c++-abi-vtables -o - \| FileCheck %s --check-prefix=NO-RELATIVE-VTABLE

				#if __has_feature(cxx_abi_relative_vtable)
				int has_relative_vtable();
				#else
				int has_no_relative_vtable();
				#endif

				// RELATIVE-VTABLE: has_relative_vtable
				// NO-RELATIVE-VTABLE: has_no_relative_vtable

This is an archive of the discontinued LLVM Phabricator instance.

[clang][feature] Add cxx_abi_relative_vtable featureClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 297011

clang/include/clang/Basic/Features.def

clang/test/Lexer/has_feature_cxx_abi_relative_vtable.cpp

[clang][feature] Add cxx_abi_relative_vtable feature
ClosedPublic