Page MenuHomePhabricator

[AMDGPU] Fix missed SI_RETURN_TO_EPILOG in pre-emit peephole
ClosedPublic

Authored by critson on Aug 12 2020, 8:54 PM.

Details

Summary

SIPreEmitPeephole does not process all terminators, which means
it can fail to handle SI_RETURN_TO_EPILOG if immediately preceeded
by a branch to the early exit block.

Diff Detail

Unit TestsFailed

TimeTest
140 mswindows > lld.MachO/invalid::invalid-stub.s
Script: -- : 'RUN: at line 2'; mkdir -p C:\ws\w32-1\llvm-project\premerge-checks\build\tools\lld\test\MachO\invalid\Output\invalid-stub.s.tmp

Event Timeline

critson created this revision.Aug 12 2020, 8:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 12 2020, 8:54 PM
critson requested review of this revision.Aug 12 2020, 8:54 PM
critson updated this revision to Diff 285251.Aug 12 2020, 9:12 PM
  • Rebase on to pre-committed test.
rampitec accepted this revision.Aug 12 2020, 10:55 PM
This revision is now accepted and ready to land.Aug 12 2020, 10:55 PM
This revision was landed with ongoing or failed builds.Aug 13 2020, 5:53 AM
This revision was automatically updated to reflect the committed changes.