Free the memory allocated by mlirOperationStateAddXXX methods in mlirOperationCreate.

[Jing]

Summary

Previously, the memory leaks on heap. Since the MlirOperationState is not intended to be used again after mlirOperationCreate, the patch simplify frees the memory in mlirOperationCreate instead of creating any new API.

[ftynse]

Hmm, apparently I uploaded the patch, but landed the previous version. Thanks!

[Jing]

Thanks! I don't have commit access. Can someone help me land it?

mlir/lib/CAPI/IR/IR.cpp

MlirOperation mlirOperationCreate(const MlirOperationState *state) {
   cppState.attributes.reserve(state->nAttributes);
   for (unsigned i = 0; i < state->nAttributes; ++i)
     cppState.addAttribute(state->attributes[i].name,
                           unwrap(state->attributes[i].attribute));
 
   for (unsigned i = 0; i < state->nRegions; ++i)
     cppState.addRegion(std::unique_ptr<Region>(unwrap(state->regions[i])));
 
+  free(state->results);
+  free(state->operands);
+  free(state->regions);
+  free(state->successors);
+  free(state->attributes);
+
   return wrap(Operation::create(cppState));
 }
 
 void mlirOperationDestroy(MlirOperation op) { unwrap(op)->erase(); }
 
 int mlirOperationIsNull(MlirOperation op) { return unwrap(op) == nullptr; }
 
 unsigned mlirOperationGetNumRegions(MlirOperation op) {