Page MenuHomePhabricator

[clang] Allow DynTypedNode to store a TemplateArgumentLoc
ClosedPublic

Authored by nridge on Aug 9 2020, 5:39 PM.

Details

Summary

The patch also adds a templateArgumentLoc() AST matcher.

Diff Detail

Event Timeline

nridge created this revision.Aug 9 2020, 5:39 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 9 2020, 5:39 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nridge requested review of this revision.Aug 9 2020, 5:39 PM
hokein accepted this revision.Aug 9 2020, 11:45 PM

Thanks.

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

This revision is now accepted and ready to land.Aug 9 2020, 11:45 PM
nridge updated this revision to Diff 284264.Aug 10 2020, 12:06 AM

Run script to update AST matcher docs

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

Done. Note, it looks like this script needs to be run with python 2. Should we document this somewhere?

This revision was landed with ongoing or failed builds.Aug 10 2020, 12:09 AM
This revision was automatically updated to reflect the committed changes.

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

Done. Note, it looks like this script needs to be run with python 2. Should we document this somewhere?

Given that python2 is EOL I think the correct course of action is to make it work with python3.

Please run clang/docs/tools/dump_ast_matchers.py script to update the LibASTMatchersReference.html file.

Done. Note, it looks like this script needs to be run with python 2. Should we document this somewhere?

Given that python2 is EOL I think the correct course of action is to make it work with python3.

Filed https://bugs.llvm.org/show_bug.cgi?id=47102 for this.