We have gnu-phdrs.test that tests
-l, --program-headers and --segments options for llvm-readelf.
We also have:
- program-headers.test that tests --program-headers and -l for llvm-readobj. It doesn't test --segments and also uses lots of precompiled objects. It is very incomplete in compare with the gnu-phdrs.test.
- pt-gnu-property.test that contains a simple test for the PT_GNU_PROPERTY segment. There is no reason to have it in a separate file.
This patch:
- Merges program-headers.test and pt-gnu-property.test to gnu-phdrs.test.
- Removes 2 precompiled binaries used by program-headers.test (other ones are still used by another tests).
Could these just change to calling FileCheck with the text file as an input file:
Also, it might be wise to add at least --match-full-lines to all llvm-readobj checks, because it will prevent numeric values spuriously matching when there are more digits. For example, without it CHECK: Value: 0x1234 would also match Value: 0x12345678, I believe.