[NFC][StackSafety] Test that StackLifetime looks through stripPointerCasts

[ChuanqiXu]

Summary

StackLifetime class collects lifetime marker of an alloca by collect
the user of BitCast who is the user of the alloca. However, either
the alloca itself could be used with the lifetime marker or the BitCast
of the alloca could be transformed to other instructions. (e.g.,
it may be transformed to all zero reps in InstCombine pass).
This patch tries to fix this process in collectMarkers functions.

[RKSimon]

test case?

[ChuanqiXu]

This comment was removed by ChuanqiXu.

[ChuanqiXu]

Update test case

[ChuanqiXu]

In D85399#2199566, @RKSimon wrote:

test case?

Sorry, it's my fault to forget to update the test case. I update it now. The IR in the test file is generated by command clang -O2 -S -emit-llvm for the following code:

typedef struct  {
    char a[500];
} char_array;

void consume(char_array);

void simple(int cond) {
    if (cond) {
        char_array a;
        consume(a);
    } else {
        char_array b;
        consume(b);
    }
}

[ChuanqiXu]

@RKSimon , gentle ping~

[vitalybuka]

This function was changed
Is this issue still relevant?
If this is still needed, could you please make this a regular lit test?

[ChuanqiXu]

In D85399#2223309, @vitalybuka wrote:

This function was changed
Is this issue still relevant?
If this is still needed, could you please make this a regular lit test?

Thanks for your comment. This issue is fixed by the new commit. I don't know how to add this a regular lit test because StackLifetime module won't provide a pass interface, which means I can call it from opt.

[vitalybuka]

The test is still could be useful
Maybe something like this llvm/test/Analysis/StackSafetyAnalysis/lifetime.ll ?

[ChuanqiXu]

In D85399#2223329, @vitalybuka wrote:

The test is still could be useful
Maybe something like this llvm/test/Analysis/StackSafetyAnalysis/lifetime.ll ?

Oh, I find here is StackLifetimePrinterPass which I can use for tests. I updated the diff about test case to lifetime.ll for now.

[vitalybuka]

cleanup

[vitalybuka]

LGTM with some updates

[ChuanqiXu]

In D85399#2225025, @vitalybuka wrote:

LGTM with some updates

Thank you very much !!!

llvm/test/Analysis/StackSafetyAnalysis/lifetime.ll

; CHECK-NEXT: Alive: <x>
   call void @llvm.lifetime.start.p0i8(i64 4, i8* %x)
 ; CHECK: call void @llvm.lifetime.start.p0i8(i64 4, i8* %x)
 ; CHECK-NEXT: Alive: <x>
 
   call void @capture8(i8* %x)
   br label %l2
 }
 
+%struct.char_array = type { [500 x i8] }
+
+define dso_local void @gep_test(i32 %cond)  {
+; CHECK-LABEL: define dso_local void @gep_test
+entry:
+; CHECK: entry:
+; CHECK-NEXT: Alive: <>
+  %a = alloca %struct.char_array, align 8
+  %b = alloca %struct.char_array, align 8
+  %tobool.not = icmp eq i32 %cond, 0
+  br i1 %tobool.not, label %if.else, label %if.then
+
+if.then:                                          ; preds = %entry
+; CHECK: if.then:
+; CHECK-NEXT: Alive: <>
+  %0 = getelementptr inbounds %struct.char_array, %struct.char_array* %a, i64 0, i32 0, i64 0
+  call void @llvm.lifetime.start.p0i8(i64 500, i8* nonnull %0)
+; CHECK: call void @llvm.lifetime.start.p0i8(i64 500, i8* nonnull %0)
+; CHECK-NEXT: Alive: <a>
+  tail call void @capture8(i8* %0)
+  call void @llvm.lifetime.end.p0i8(i64 500, i8* nonnull %0)
+; CHECK: call void @llvm.lifetime.end.p0i8(i64 500, i8* nonnull %0)
+; CHECK-NEXT: Alive: <>
+  br label %if.end
+
+if.else:                                          ; preds = %entry
+; CHECK: if.else:
+; CHECK-NEXT: Alive: <>
+  %1 = getelementptr inbounds %struct.char_array, %struct.char_array* %b, i64 0, i32 0, i64 0
+  call void @llvm.lifetime.start.p0i8(i64 500, i8* nonnull %1)
+; CHECK: call void @llvm.lifetime.start.p0i8(i64 500, i8* nonnull %1)
+; CHECK-NEXT: Alive: <b>
+  tail call void @capture8(i8* %1)
+  call void @llvm.lifetime.end.p0i8(i64 500, i8* nonnull %1)
+; CHECK: call void @llvm.lifetime.end.p0i8(i64 500, i8* nonnull %1)
+; CHECK-NEXT: Alive: <>
+  br label %if.end
+
+if.end:                                           ; preds = %if.else, %if.then
+; CHECK: if.end:
+; CHECK-NEXT: Alive: <>
+  ret void
+}
+
 define void @if_must(i1 %a) {
 ; CHECK-LABEL: define void @if_must
 entry:
 ; CHECK: entry:
 ; CHECK-NEXT: Alive: <>
   %x = alloca i8, align 4
   %y = alloca i8, align 4