[DebugInfo] Simplify DIEInteger::SizeOf().

[ikudrin]

Summary

An AsmPrinter should always be provided to the method because some forms depend on its parameters. The only place in the codebase which passed a nullptr value was found in the unit tests, so the patch updates it to use some dummy AsmPrinter instead.

[ikudrin]

D87008 added creating a test AsmPrinter to the CodeGen unit tests, so it is now possible to fix the DIEHashTest.MemberBlock so that it provides an instance to the tested class.

[dblaikie]

Looks good - thanks!

llvm/unittests/CodeGen/DIEHashTest.cpp

34–39 ↗

(On Diff #292203)

I'd probably roll this into getAsmPrinter - but up to you.

[ikudrin]

llvm/unittests/CodeGen/DIEHashTest.cpp

34–39 ↗

(On Diff #292203)

ASSERT_THAT_EXPECTED breaks compilation if placed in a non-void function.

[dblaikie]

llvm/unittests/CodeGen/DIEHashTest.cpp

34–39 ↗

(On Diff #292203)

Fair enough - seems a bit subtle, but I don't have great alternative suggestions. Thanks for explaining!

llvm/lib/CodeGen/AsmPrinter/DIE.cpp

case dwarf::DW_FORM_sdata:
     return;
   default: llvm_unreachable("DIE Value form not supported yet");
   }
 }
 
 /// SizeOf - Determine size of integer value in bytes.
 ///
 unsigned DIEInteger::SizeOf(const AsmPrinter *AP, dwarf::Form Form) const {
-  dwarf::FormParams Params = {0, 0, dwarf::DWARF32};
-  if (AP)
-    Params = {AP->getDwarfVersion(), uint8_t(AP->getPointerSize()),
+  assert(AP && "AsmPrinter is required to set FormParams");
+  dwarf::FormParams Params = {AP->getDwarfVersion(),
+                              uint8_t(AP->getPointerSize()),
                               AP->OutStreamer->getContext().getDwarfFormat()};
 
   if (Optional<uint8_t> FixedSize = dwarf::getFixedFormByteSize(Form, Params))
     return *FixedSize;
 
   switch (Form) {
   case dwarf::DW_FORM_GNU_str_index:
   case dwarf::DW_FORM_GNU_addr_index:
   case dwarf::DW_FORM_ref_udata: