This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Semantic highlighting for dependent template name in template argument
ClosedPublic

Authored by nridge on Aug 4 2020, 8:33 PM.

Diff Detail

Event Timeline

nridge created this revision.Aug 4 2020, 8:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 4 2020, 8:34 PM
nridge requested review of this revision.Aug 4 2020, 8:34 PM
hokein accepted this revision.Aug 5 2020, 1:34 AM
hokein added a subscriber: hokein.
hokein added inline comments.
clang-tools-extra/clangd/SemanticHighlighting.cpp
305

nit: move the trailing ; to a new line.

This revision is now accepted and ready to land.Aug 5 2020, 1:34 AM
nridge added inline comments.Aug 5 2020, 8:11 AM
clang-tools-extra/clangd/SemanticHighlighting.cpp
305

I have done this, but clang-format moves it back... do we really want to fight wit it?

nridge updated this revision to Diff 283784.Aug 6 2020, 6:22 PM

Address nit

nridge marked an inline comment as done.Aug 6 2020, 6:22 PM
nridge added inline comments.
clang-tools-extra/clangd/SemanticHighlighting.cpp
305

I wrote it as:

default:
  break;

instead, I think that may be more idiomatic anyways.

nridge edited the summary of this revision. (Show Details)Aug 6 2020, 6:23 PM
This revision was landed with ongoing or failed builds.Aug 6 2020, 6:24 PM
This revision was automatically updated to reflect the committed changes.