If an analysis is actually invalidated, there's already a log statement
for that: 'Invalidating analysis: FooAnalysis'.
Otherwise the statement is not very useful.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
llvm/include/llvm/IR/PassManagerImpl.h | ||
---|---|---|
131 | At this point, does this message still add anything? If this message gets printed, then at least one "Invalidating analysis" message will get printed as well, and that message also includes IR.getName(). |
llvm/include/llvm/IR/PassManagerImpl.h | ||
---|---|---|
131 | Yes you're right. I went ahead and deleted it all. |
Comment Actions
It does not reveal more information than 'Invalidating analysis:' and it could show up even if no analyses need to be invalidated for the IR. So LGTM.
At this point, does this message still add anything? If this message gets printed, then at least one "Invalidating analysis" message will get printed as well, and that message also includes IR.getName().