This is an archive of the discontinued LLVM Phabricator instance.

GlobalISel: Implement fewerElementsVector for G_INSERT_VECTOR_ELT
ClosedPublic

Authored by arsenm on Jul 28 2020, 7:29 AM.

Details

Summary

Add unit tests since AMDGPU will only trigger this for gigantic
vectors, and won't use the annoying odd sized breakdown case.

Diff Detail

Event Timeline

arsenm created this revision.Jul 28 2020, 7:29 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 28 2020, 7:29 AM
arsenm requested review of this revision.Jul 28 2020, 7:29 AM
paquette added inline comments.Jul 28 2020, 2:59 PM
llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
283

phab is complaining about these (>>), are they tabs? clang format?

arsenm added inline comments.Jul 29 2020, 5:22 AM
llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
283

I don't think this is a complaint. It's definitely not a tab. Maybe this is just marking the line didn't change, only the indentation point?

aemerson added inline comments.Aug 12 2020, 11:37 AM
llvm/include/llvm/CodeGen/GlobalISel/LegalizerHelper.h
283

Yeah I think that's it.

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
3618

Can fold these into just a single assert: assert(IsInsert ? TypeIdx == 0 : TypeIdx == 1)

3653

A comment in this block explaining the approach would be helpful.

arsenm updated this revision to Diff 285364.Aug 13 2020, 7:07 AM
arsenm marked 2 inline comments as done.

Address comments

aemerson accepted this revision.Aug 18 2020, 10:34 AM
This revision is now accepted and ready to land.Aug 18 2020, 10:34 AM