Page MenuHomePhabricator
Differential D84691

[CMake] Move find_package(ZLIB) to LLVMConfig
ClosedPublic
Actions

Authored by phosek on Jul 27 2020, 11:58 AM.

Details

Reviewers
smeenai
compnerd
mehdi_amini
Commits
rG64d99cc6abed: [CMake] Move find_package(ZLIB) to LLVMConfig
Summary

This way, downstream projects don't have to invoke find_package(ZLIB)
reducing the amount of boilerplate.

Diff Detail

Event Timeline

phosek created this revision.Jul 27 2020, 11:58 AM
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJul 27 2020, 11:58 AM
Herald added subscribers: llvm-commits, lldb-commits, cfe-commits and 17 others. · View Herald Transcript
phosek mentioned this in D79219: [CMake] Simplify CMake handling for zlib.Jul 27 2020, 11:59 AM
Harbormaster failed remote builds in B65895: Diff 281007!Jul 27 2020, 1:54 PM
compnerd accepted this revision.Jul 27 2020, 3:04 PM

Thanks, this is a great idea!

This revision is now accepted and ready to land.Jul 27 2020, 3:04 PM
mehdi_amini added a comment.Jul 27 2020, 5:11 PM

Thanks!

Closed by commit rG64d99cc6abed: [CMake] Move find_package(ZLIB) to LLVMConfig (authored by phosek). · Explain WhyJul 27 2020, 5:14 PM
This revision was automatically updated to reflect the committed changes.
stephenneuendorffer added a comment.Jul 27 2020, 5:17 PM

Perfect! Thanks!

Revision Contents
Changeset List

PathSize
clang/
4 lines
lld/
4 lines
lldb/
cmake/
modules/
4 lines
llvm/
cmake/
modules/
3 lines
mlir/
examples/
standalone/
4 lines

Diff 281085

View Options

clang/CMakeLists.txt

Loading...
View Options

lld/CMakeLists.txt

Loading...
View Options

lldb/cmake/modules/LLDBStandalone.cmake

Loading...
View Options

llvm/cmake/modules/LLVMConfig.cmake.in

Loading...
View Options

mlir/examples/standalone/CMakeLists.txt

Loading...