Page MenuHomePhabricator

[MLIR][SPIRVToLLVM] Conversion for inverse sqrt and tanh
ClosedPublic

Authored by georgemitenkov on Jul 27 2020, 3:52 AM.

Details

Summary

This is a second patch on conversion of GLSL ops to LLVM dialect.
It introduces patterns to convert spv.InverseSqrt and spv.Tanh.

Diff Detail

Event Timeline

georgemitenkov created this revision.Jul 27 2020, 3:52 AM
bondhugula added inline comments.
mlir/test/Conversion/SPIRVToLLVM/glsl-ops-to-llvm.mlir
103

CHECK-LABEL please.

110

Can drop %{{.*}}.

119

Likewise.

122

Nit: You don't need to match %{{.*}} =.

georgemitenkov marked 4 inline comments as done.

Addressed comments on style in tests.

antiagainst accepted this revision.Jul 28 2020, 5:49 PM
antiagainst added inline comments.
mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp
96

a floating point scalar or vector value

This revision is now accepted and ready to land.Jul 28 2020, 5:49 PM
This revision was automatically updated to reflect the committed changes.
georgemitenkov marked an inline comment as done.