This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Lower frem f16
ClosedPublic

Authored by foad on Jul 24 2020, 5:02 AM.

Details

Summary

Without this it would fail to select on subtargets that have 16-bit
instructions.

Diff Detail

Event Timeline

foad created this revision.Jul 24 2020, 5:02 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 24 2020, 5:02 AM
arsenm added inline comments.Jul 24 2020, 6:12 AM
llvm/test/CodeGen/AMDGPU/frem.ll
6

Can you also add a function with f32 denormals flushed? In that case the fdiv expansion could theoretically skip the mode switch

foad marked an inline comment as done.Jul 24 2020, 7:06 AM
foad added inline comments.
llvm/test/CodeGen/AMDGPU/frem.ll
6

All functions in this file already have "denormal-fp-math-f32"="preserve-sign,preserve-sign".

foad updated this revision to Diff 280532.Jul 24 2020, 11:46 AM

Rebase.

arsenm accepted this revision.Aug 4 2020, 11:23 AM
This revision is now accepted and ready to land.Aug 4 2020, 11:23 AM
This revision was automatically updated to reflect the committed changes.