Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D83939

Remove deprecated std::iterator (In Progress)
AbandonedPublic
Actions

Authored by mjp41 on Jul 16 2020, 3:55 AM.

Tags

Subscribers

george.burgess.iv

Details

Reviewers

rengolin
chandlerc

Summary

In C++17 std::iterator is deprecated, this removes the use.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	310 ms	windows > LLVM.Transforms/PhaseOrdering/X86::Unknown Unit Message ("")
	280 ms	windows > LLVM.Transforms/SimplifyCFG::Unknown Unit Message ("")
	330 ms	windows > LLVM.Transforms/SimplifyCFG::Unknown Unit Message ("")
	130 ms	windows > LLVM.Transforms/SimplifyCFG::Unknown Unit Message ("")
	120 ms	windows > LLVM.Transforms/SimplifyCFG::Unknown Unit Message ("")
		View Full Test Results (13 Failed)

Event Timeline

mjp41 created this revision.Jul 16 2020, 3:55 AM

Herald added subscribers: llvm-commits, asbirlea, dexonsmith, george.burgess.iv. · View Herald TranscriptJul 16 2020, 3:55 AM

Harbormaster failed remote builds in B64490: Diff 278418!Jul 16 2020, 5:10 AM

mjp41 retitled this revision from Remove deprecated std::iterator to Remove deprecated std::iterator (In Progress).Jul 16 2020, 6:33 AM

I have realised there are lots of instances of this. Changing all ~50 is mechanical, but a larger change than I was expecting.

This is more work that I anticipated. I will revisit if I get more time.

Revision Contents
Changeset List

Path

Size

llvm/

include/

llvm/

ADT/

12 lines

Analysis/

4 lines

Diff 278418

llvm/include/llvm/ADT/iterator.h

Loading...

llvm/include/llvm/Analysis/MemorySSA.h

Loading...