Page MenuHomePhabricator

mjp41 (Matthew Parkinson)
User

Projects

User does not belong to any projects.

User Details

User Since
Aug 20 2018, 1:26 AM (148 w, 1 d)

Recent Activity

Feb 3 2021

mjp41 requested review of D95933: Fix MLIR Async Runtime DLL on Windows.
Feb 3 2021, 2:25 AM · Restricted Project

Feb 2 2021

mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

Just to follow up. The tests for the ExecutionEngine as far as I can see do not run on Windows. Getting tests for the ExecutionEngine working on Windows seems like a larger undertaking, than I can currently do, and would require checking a lot of code I am not familiar with. My limited experiment seems to imply the changes I have made would help with making the MLIR execution engine work on Windows.

Feb 2 2021, 9:36 AM · Restricted Project

Jan 29 2021

mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

So after a little fiddling, I manually ran a test:

> bin\mlir-opt.exe ..\mlir\integration_test\Dialect\Async\CPU\test-async-parallel-for-1d.mlir -async-parallel-for -async-ref-counting  -convert-async-to-llvm  -convert-scf-to-std  -convert-std-to-llvm | bin\mlir-cpu-runner.exe -e entry -entry-point-result=void -O0 -shared-libs=bin\mlir_async_runtime.dll -shared-libs=bin\mlir_runner_utils.dll | bin\FileCheck --dump-input=always ..\mlir\integration_test\Dialect\Async\CPU\test-async-parallel-for-1d.mlir
Jan 29 2021, 3:16 AM · Restricted Project

Jan 27 2021

mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

So -DBUILD_SHARED_LIBS=ON is not supported on Windows. I had the same failures with and without this patch for MLIR integration tests. So I have done as much as I can to know this is not going to regress anything.

Jan 27 2021, 10:52 AM · Restricted Project
mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

@rengolin, I manually checked the DLL symbols contained __mlir_runner_init and __mlir_runner_destroy and nothing else. But I didn't know a command line that I could use to test if this what the context for loading this was expecting.

Jan 27 2021, 3:55 AM · Restricted Project
mjp41 updated the diff for D95386: Fix namespace for MLIR Async Runtime.

Updated to export the symbols as suggested by @ezhulenev.

Jan 27 2021, 3:10 AM · Restricted Project

Jan 26 2021

mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

@ezhulenev I think I can see what the fix should be. Does the check-mlir cover this example? Or is there additional testing I should do?

Jan 26 2021, 6:15 AM · Restricted Project
mjp41 added a reviewer for D95386: Fix namespace for MLIR Async Runtime: theraven.
Jan 26 2021, 3:18 AM · Restricted Project
mjp41 updated the diff for D95386: Fix namespace for MLIR Async Runtime.
Jan 26 2021, 2:57 AM · Restricted Project
mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

I am not sure what the correct approach to this should be given the new code for the JIT. Do you need to dllexport the __mlir_runner_init code, so that it appears in the DLL? Do you actually want the other symbols in the dll, or just use the export_symbol in the __mlir_runner_init?

Jan 26 2021, 2:35 AM · Restricted Project
mjp41 updated the diff for D95386: Fix namespace for MLIR Async Runtime.
Jan 26 2021, 2:31 AM · Restricted Project

Jan 25 2021

mjp41 abandoned D95386: Fix namespace for MLIR Async Runtime.

Closing as code has changed.

Jan 25 2021, 12:17 PM · Restricted Project
mjp41 added a comment to D95386: Fix namespace for MLIR Async Runtime.

The following minimised example shows the Visual Studio behaviour

C++
namespace foo
{
    extern "C" __declspec(dllexport) int f();
    extern "C" __declspec(dllexport) int g();
}
Jan 25 2021, 12:06 PM · Restricted Project
mjp41 requested review of D95386: Fix namespace for MLIR Async Runtime.
Jan 25 2021, 11:59 AM · Restricted Project

Jul 16 2020

mjp41 abandoned D83939: Remove deprecated std::iterator (In Progress).

This is more work that I anticipated. I will revisit if I get more time.

Jul 16 2020, 7:46 AM · Restricted Project
mjp41 added a comment to D83939: Remove deprecated std::iterator (In Progress).

I have realised there are lots of instances of this. Changing all ~50 is mechanical, but a larger change than I was expecting.

Jul 16 2020, 6:35 AM · Restricted Project
mjp41 retitled D83939: Remove deprecated std::iterator (In Progress) from Remove deprecated std::iterator to Remove deprecated std::iterator (In Progress).
Jul 16 2020, 6:33 AM · Restricted Project
mjp41 created D83939: Remove deprecated std::iterator (In Progress).
Jul 16 2020, 3:55 AM · Restricted Project

May 5 2020

mjp41 updated the diff for D79317: Check type for forward reference definition.

Updated error message inline with feedback.

May 5 2020, 1:34 AM · Restricted Project, Restricted Project

May 4 2020

mjp41 updated the diff for D79317: Check type for forward reference definition.
May 4 2020, 5:18 AM · Restricted Project, Restricted Project
mjp41 removed 1 blocking reviewer(s) for D79317: Check type for forward reference definition: rriddle.
May 4 2020, 3:10 AM · Restricted Project, Restricted Project
mjp41 created D79317: Check type for forward reference definition.
May 4 2020, 3:10 AM · Restricted Project, Restricted Project

Aug 20 2018

mjp41 created D50959: Fix in getAllocationDataForFunction.
Aug 20 2018, 1:44 AM