This is an archive of the discontinued LLVM Phabricator instance.

Harmonize python shebang
ClosedPublic

Authored by serge-sans-paille on Jul 15 2020, 12:36 AM.

Details

Reviewers
arsenm
compnerd
bollu
lebedev.ri
Group Reviewers
Restricted Project
Commits
rG515bc8c1554f: Harmonize Python shebang
Summary

Before:

grep -r --include=\*.py -E '^#!' -h | sort | uniq -c

  1 #!/bin/env python
  6 #! /usr/bin/env python
162 #!/usr/bin/env python
  2 #! /usr/bin/env python3
 16 #!/usr/bin/env python3
  2 #! /usr/bin/python
 49 #!/usr/bin/python

After

grep -r --include=\*.py -E '^#!' -h | sort | uniq -c

220 #!/usr/bin/env python
 18 #!/usr/bin/env python3

I've kept python3 reference to capture the intent « this a py3 only script »

Diff Detail

Event Timeline

arsenm accepted this revision.Jul 16 2020, 5:56 AM

Consistency is good

This revision is now accepted and ready to land.Jul 16 2020, 5:56 AM

Sounds good to me too.
If this breaks some scripts previously used some different pattern, we'll, that would mean that the other scripts already using that pattern were broken already.

compnerd accepted this revision.Jul 16 2020, 10:57 AM

Thanks for making these uniform.

This revision was automatically updated to reflect the committed changes.
Herald added projects: Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project, Restricted Project. · View Herald TranscriptJul 16 2020, 12:53 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript