Page MenuHomePhabricator

[mlir][shape] Mark some operations as commutative
ClosedPublic

Authored by herhut on Jul 15 2020, 12:33 AM.

Details

Summary

This makes sure that their constant arguments are sorted to the back
and hence eases the specification of rewrite patterns.

Diff Detail

Event Timeline

herhut created this revision.Jul 15 2020, 12:33 AM
Herald added a reviewer: silvas. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
frgossen accepted this revision.Jul 15 2020, 6:45 AM
jpienaar accepted this revision.Jul 15 2020, 6:51 AM
jpienaar added inline comments.
mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td
555

This only has one argument.

This revision is now accepted and ready to land.Jul 15 2020, 6:51 AM
herhut updated this revision to Diff 278202.Jul 15 2020, 8:31 AM

Comments.

This revision was automatically updated to reflect the committed changes.