This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][SPIRVToLLVM] SPIRV function fix and nits
ClosedPublic

Authored by georgemitenkov on Jul 14 2020, 9:37 AM.

Details

Summary

This patch addresses the comments from https://reviews.llvm.org/D83030 and https://reviews.llvm.org/D82639. this-> is removed when not inside the template.
Also, spv.func is fixed: now convertRegionTypes() is used to apply type conversion on blocks within the function.

Diff Detail

Event Timeline

georgemitenkov created this revision.Jul 14 2020, 9:37 AM
rriddle accepted this revision.Jul 14 2020, 10:20 AM
rriddle added inline comments.
mlir/lib/Conversion/SPIRVToLLVM/ConvertSPIRVToLLVM.cpp
679–682

You don't need applySignatureConversion if you have convertRegionTypes.

This revision is now accepted and ready to land.Jul 14 2020, 10:20 AM
georgemitenkov marked an inline comment as done.

Removed the call to applySignatureConversion().

This revision was automatically updated to reflect the committed changes.