Page MenuHomePhabricator

[CGP] Limit converting phi types to simple loads and stores
ClosedPublic

Authored by dmgreen on Jul 14 2020, 7:06 AM.

Details

Summary

Instcombine limits converting phi types to simple loads and stores. This does the same in codegenprepare, not processing phis that are not simple.

Note that volatile loads/store ISel will happy convert between float and int. Atomics are more likely to always be integer. This just keeps things simple and doesn't process either.

Diff Detail

Event Timeline

dmgreen created this revision.Jul 14 2020, 7:06 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 14 2020, 7:06 AM
Herald added subscribers: jfb, hiraditya. · View Herald Transcript
efriedma accepted this revision.Jul 14 2020, 12:46 PM

I don't think changing the type of a volatile/atomic store should be problematic, but it's unlikely to matter anyway. So fine, LGTM.

This revision is now accepted and ready to land.Jul 14 2020, 12:46 PM