Page MenuHomePhabricator

tbosch (Tobias Bosch)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 20 2020, 4:27 PM (31 w, 3 d)

Recent Activity

Jun 26 2020

tbosch added a comment to D82487: [InstCombine] Drop debug loc in TryToSinkInstruction.

Thanks!

Jun 26 2020, 5:20 PM · Restricted Project
tbosch added a comment to D82487: [InstCombine] Drop debug loc in TryToSinkInstruction.

Hello Vedant,
this broke our internal llvm bootstrap with errors like this:

Jun 26 2020, 3:10 PM · Restricted Project

Jun 25 2020

tbosch added a comment to D81827: [CGP] Convert phi types.

David, I sent you an email with a reproduction.

Jun 25 2020, 6:02 PM · Restricted Project
tbosch accepted D82605: [CMake] Add check-debuginfo-* targets.
Jun 25 2020, 3:50 PM · Restricted Project

Jun 23 2020

tbosch added a comment to D81827: [CGP] Convert phi types.

FYI, working on a reduction. Will have it hopefully tomorrow.

Jun 23 2020, 5:49 PM · Restricted Project

Jun 18 2020

tbosch added a comment to D81319: [Dexter] Add --source-dir-root flag.

@TWeaver @jmorse It looks like both of you gave an implicit LGTM, is that correct?

I will wait one more day then submit this change so that it doesn't bit rot.

(aside: Generally once something's been sent for review it should not be committed until approved (otherwise it muddies the waters a bit - it was sent for review because the author felt it needed review, but then committed without it?))

Jun 18 2020, 12:01 PM · debug-info, Restricted Project
tbosch committed rG53d6bfef32e3: [Dexter] Add --source-dir-root flag (authored by tbosch).
[Dexter] Add --source-dir-root flag
Jun 18 2020, 9:47 AM
tbosch closed D81319: [Dexter] Add --source-dir-root flag.
Jun 18 2020, 9:46 AM · debug-info, Restricted Project

Jun 17 2020

tbosch added a comment to D81319: [Dexter] Add --source-dir-root flag.

@TWeaver @jmorse It looks like both of you gave an implicit LGTM, is that correct?

Jun 17 2020, 5:17 PM · debug-info, Restricted Project

Jun 15 2020

tbosch added a comment to D81319: [Dexter] Add --source-dir-root flag.

@TWeaver @jmorse Is this good to go now from your side?

Jun 15 2020, 7:33 AM · debug-info, Restricted Project

Jun 11 2020

tbosch added a comment to D81319: [Dexter] Add --source-dir-root flag.

Ok, tried to apply your comments. Could you take another look?

Jun 11 2020, 12:07 PM · debug-info, Restricted Project
tbosch added inline comments to D81319: [Dexter] Add --source-dir-root flag.
Jun 11 2020, 11:34 AM · debug-info, Restricted Project
tbosch updated the diff for D81319: [Dexter] Add --source-dir-root flag.

Applied first round of comments.

Jun 11 2020, 11:34 AM · debug-info, Restricted Project

Jun 10 2020

tbosch added a comment to D81319: [Dexter] Add --source-dir-root flag.

Hey and thanks for this!

If I understand this correctly, this patch is trying to solve the problem of source files being moved from the path/dir that they were originally in to a new dir after the binary we pass via --binary has been compiled. This problem occurs because the file in which we store our dexter commands is also the file path associated with the commands. If we move the source file, we change the expectations and these may no longer align with the pre-compiled binary.

Whilst I have no misgivings about the way in which this problem is solved, using a --source-dir option, I am, however, hesitant to condone the implementation being in DebuggerBase. DebuggerBase and the subsequent debuggers' jobs are concerned with exposing debugger features, not with contending with the test environment in which dexter is run.

As such, my preference would be a solution that handles this case lower in the stack, preferably in the Test tool, which is concerned with handling the test environment.

You could potentially do the external_to_debug mapping before passing context to the debugger controller. run the debugger and then remap the debug_to_external locations in the test tool before passing the watch data off to the heuristic scorer.

Please let me know if there's any issues or if you have any concerns yourself.

Thanks again,

Jun 10 2020, 11:48 AM · debug-info, Restricted Project

Jun 9 2020

tbosch added reviewers for D81319: [Dexter] Add --source-dir-root flag: probinson, debug-info.
Jun 9 2020, 6:15 PM · debug-info, Restricted Project

Jun 5 2020

tbosch added a reviewer for D81319: [Dexter] Add --source-dir-root flag: jmorse.
Jun 5 2020, 4:48 PM · debug-info, Restricted Project
tbosch added a reviewer for D81319: [Dexter] Add --source-dir-root flag: TWeaver.
Jun 5 2020, 4:48 PM · debug-info, Restricted Project
tbosch created D81319: [Dexter] Add --source-dir-root flag.
Jun 5 2020, 4:48 PM · debug-info, Restricted Project

May 29 2020

tbosch committed rG6a4714030e46: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes. (authored by tbosch).
[DebugInfo][DAG] Don't reuse debug location on COPY if width changes.
May 29 2020, 1:42 PM
tbosch closed D80819: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes..
May 29 2020, 1:41 PM · Restricted Project
tbosch updated the diff for D80819: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes..

Do the width check at the right time

May 29 2020, 12:00 PM · Restricted Project
tbosch updated subscribers of D80819: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes..
May 29 2020, 10:53 AM · Restricted Project
tbosch created D80819: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes..
May 29 2020, 10:53 AM · Restricted Project
tbosch added a reviewer for D80819: [DebugInfo][DAG] Don't reuse debug location on COPY if width changes.: vsk.
May 29 2020, 10:53 AM · Restricted Project

May 13 2020

tbosch added a comment to D79897: Only run pretty-printer tests for builds with debug-info..

Nice, this fixes https://bugs.llvm.org/show_bug.cgi?id=45652

May 13 2020, 5:29 PM · Restricted Project

Apr 29 2020

tbosch committed rG6a53ab82d777: [SVE][NFC] Remove unused variable (authored by tbosch).
[SVE][NFC] Remove unused variable
Apr 29 2020, 2:35 PM
tbosch closed D79129: [SVE][NFC] Remove unused variable.
Apr 29 2020, 2:34 PM · Restricted Project
tbosch created D79129: [SVE][NFC] Remove unused variable.
Apr 29 2020, 2:33 PM · Restricted Project

Apr 21 2020

tbosch added a comment to D76926: [Dexter] Add Debugger Controller To Dexter.

Thanks, just verified that this is fixed for me too.

Apr 21 2020, 9:41 AM · Restricted Project, debug-info

Apr 20 2020

tbosch added a comment to D76926: [Dexter] Add Debugger Controller To Dexter.

Hello, I believe this broke the test "clang-opt-bisect" (ran at ee12edcb76423c78b55cdddae2edfe45cbb2ccd6):

Apr 20 2020, 5:22 PM · Restricted Project, debug-info
tbosch added a comment to rG1a0f7a2077b7: [DebugInfo@O2][LoopVectorize] pr39024: Vectorized code linenos step through….

Hello, I believe this broke the clang-opt-bisect.cpp test (see the failure below that I am getting with a checkout from today (@ee12edcb76423c78b55cdddae2edfe45cbb2ccd6):

Apr 20 2020, 4:50 PM