This is an archive of the discontinued LLVM Phabricator instance.

[ods] Enable getting forward decls allow
ClosedPublic

Authored by jpienaar on Jul 13 2020, 3:53 PM.

Details

Summary

Currently forward decls are included with all the op classes. But there are cases (say when splitting up headers) where one wants the forward decls but not all the classes. Add an option to enable this. This does not change any current behavior (some further refactoring is probably due here).

Diff Detail

Event Timeline

jpienaar created this revision.Jul 13 2020, 3:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 13 2020, 3:53 PM
jpienaar updated this revision to Diff 277600.Jul 13 2020, 3:54 PM

Skipped clang-format check accidentally

mehdi_amini accepted this revision.Jul 13 2020, 9:49 PM

Something that came up internally was to try to move away from the pattern where we define a macro and includes the same file and instead emit multiple files in the first place, would we have one for fwd decl and one for the class decl?

This revision is now accepted and ready to land.Jul 13 2020, 9:49 PM

Something that came up internally was to try to move away from the pattern where we define a macro and includes the same file and instead emit multiple files in the first place, would we have one for fwd decl and one for the class decl?

Yes. I mean we'd then effectively have 4 here then 1) fwd decl, 2) class decl, 3) class defn, 4) op list.

This revision was automatically updated to reflect the committed changes.