Page MenuHomePhabricator

[mlir] Print 0 element DenseElementsAttr as dense<> to fix parser bugs with expected shape.
ClosedPublic

Authored by rriddle on Jul 8 2020, 5:44 PM.

Details

Summary

Depending on where the 0 dimension is within the shape, the parser will currently reject .mlir generated by the printer.

Diff Detail

Event Timeline

rriddle created this revision.Jul 8 2020, 5:44 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2020, 5:44 PM
GMNGeoffrey accepted this revision.Jul 8 2020, 6:00 PM
GMNGeoffrey added a subscriber: GMNGeoffrey.

Not sure if my approval counts, but...

Thanks River :-D

This revision is now accepted and ready to land.Jul 8 2020, 6:00 PM
jpienaar accepted this revision.Jul 8 2020, 6:42 PM

Thanks (even removes need for regex in testing :-))

This revision was automatically updated to reflect the committed changes.