This is an archive of the discontinued LLVM Phabricator instance.

Differential D83426

Unbreak Clang standalone build.
ClosedPublic

Authored by michele.scandale on Jul 8 2020, 2:06 PM.

Details

Reviewers
chandlerc
beanz
compnerd
Commits
rGaa7a5ad56b60: repair standalone clang builds
Summary

Add missing C++ language standard setup for Clang standalone build.

Diff Detail

Event Timeline

michele.scandale created this revision.Jul 8 2020, 2:06 PM
Herald added a project: Restricted Project. · View Herald TranscriptJul 8 2020, 2:06 PM
Herald added subscribers: cfe-commits, mgorny. · View Herald Transcript
Harbormaster completed remote builds in B63486: Diff 276548.Jul 8 2020, 2:52 PM
michele.scandale added a reviewer: beanz.Jul 8 2020, 9:38 PM
michele.scandale added a reviewer: compnerd.
compnerd accepted this revision.Jul 9 2020, 9:18 AM

Seems reasonable to me, this seems like it would be useful to downstream packagers for Linux distros.

This revision is now accepted and ready to land.Jul 9 2020, 9:18 AM
michele.scandale added a comment.Jul 9 2020, 1:42 PM

Thanks.

Would you be able to land this on my behalf?

michele.scandale mentioned this in D83454: [CMake] Make `intrinsics_gen` dependency unconditional..Jul 9 2020, 2:45 PM
Closed by commit rGaa7a5ad56b60: repair standalone clang builds (authored by compnerd). · Explain WhyJul 10 2020, 9:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
clang/
4 lines

Diff 277076

clang/CMakeLists.txt

cmake_minimum_required(VERSION 3.4.3) cmake_minimum_required(VERSION 3.4.3)
if(POLICY CMP0075) if(POLICY CMP0075)
cmake_policy(SET CMP0075 NEW) cmake_policy(SET CMP0075 NEW)
endif() endif()
# If we are not building as a part of LLVM, build Clang as an # If we are not building as a part of LLVM, build Clang as an
# standalone project, using LLVM as an external library: # standalone project, using LLVM as an external library:
if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR ) if( CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR )
project(Clang) project(Clang)
set(CMAKE_CXX_STANDARD 14 CACHE STRING "C++ standard to conform to")
set(CMAKE_CXX_STANDARD_REQUIRED YES)
set(CMAKE_CXX_EXTENSIONS NO)
# Rely on llvm-config. # Rely on llvm-config.
set(CONFIG_OUTPUT) set(CONFIG_OUTPUT)
if(LLVM_CONFIG) if(LLVM_CONFIG)
set (LLVM_CONFIG_FOUND 1) set (LLVM_CONFIG_FOUND 1)
message(STATUS "Found LLVM_CONFIG as ${LLVM_CONFIG}") message(STATUS "Found LLVM_CONFIG as ${LLVM_CONFIG}")
message(DEPRECATION "Using llvm-config to detect the LLVM installation is \ message(DEPRECATION "Using llvm-config to detect the LLVM installation is \
deprecated. The installed cmake files should be used \ deprecated. The installed cmake files should be used \
instead. CMake should be able to detect your LLVM install \ instead. CMake should be able to detect your LLVM install \
▲ Show 20 Lines • Show All 882 Lines • Show Last 20 Lines