- Create a pass that generates bugs based on trivially defined behavior for the purpose of testing the MLIR Reduce Tool.
- Implement the functionality inside the pass to crash mlir-opt in the presence of an operation with the name "crashOp".
- Register the pass as a test pass in the mlir-opt tool.
jpienaar tpopp stephenneuendorffer
- rG16e9ccb2be7a: Create TestReducer pass
Also, don't use XFAIL: it means that the test is failing.
The initial exit code of the crash is 134. When I use the 'not' keyword it changes it to 1. Should I change the fatal_error call used to produce the crash to an error that produces an exit code of 1?
- Modify naming from test reduce to test reducer
- Add mlir-opt test case without test-mlir-reducer pass
|9 ↗||(On Diff #276538)|
Perhaps instead of bugs, error reproducers?
|42 ↗||(On Diff #276538)|
How about just checking for test.crashOp? (e.g., if dialect foo has a crashOp we should ignore it). You should be able to compare the stringref to the constant directly
|44 ↗||(On Diff #276538)|
|51 ↗||(On Diff #276538)|
generating failures ? (depends on if you intend this to just crash or not, else you can say generating crashes)
There is something fishy here... not will turn any non 0 exit code into a 0.
- Modify error to exit with code 1
- Modify testcase to use the 'not' keyword
- Change 'bug' wording to 'failure'