[analyzer][tests] Fix zip unpacking

[NoQ]

For my own education, what was wrong with join?

[vsavchenko]

I think that the problem is actually with the second '/', but I decided to retreat back to the form consistent to the rest glob.glob invocations in this file

[NoQ]

I think that the problem is actually with the second '/'

I thought the OS always ignores those? Ok anyway fair enough!

[vsavchenko]

In D83374#2139505, @NoQ wrote:

I thought the OS always ignores those? Ok anyway fair enough!

I thought so too, but it looks like glob works in mysterious ways

clang/utils/analyzer/SATestBuild.py

def _download_from_git(self, directory: str, build_log_file: IO):
         check_call(f"git clone --recursive {self.project.origin} {cached_source}",
                    cwd=directory, stderr=build_log_file,
                    stdout=build_log_file, shell=True)
         check_call(f"git checkout --quiet {self.project.commit}",
                    cwd=cached_source, stderr=build_log_file,
                    stdout=build_log_file, shell=True)
 
     def _unpack_zip(self, directory: str, build_log_file: IO):
-        zip_files = list(glob.glob(os.path.join(directory, "/*.zip")))
+        zip_files = list(glob.glob(directory + "/*.zip"))
 
         if len(zip_files) == 0:
             raise ValueError(
                 f"Couldn't find any zip files to unpack for the "
                 f"'{self.project.name}' project")
 
         if len(zip_files) > 1:
             raise ValueError(