This is an archive of the discontinued LLVM Phabricator instance.

[clangd] Enable reading config from files by default.
ClosedPublic

Authored by sammccall on Jul 6 2020, 8:23 AM.

Diff Detail

Event Timeline

sammccall created this revision.Jul 6 2020, 8:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 6 2020, 8:23 AM
hokein added inline comments.Jul 7 2020, 12:31 AM
clang-tools-extra/clangd/tool/ClangdMain.cpp
436

nit: maybe worth mentioning that the user config has higher privilege.

440

nit: I'd keep this flag off in this patch, and flip it in a new patch.

kadircet added inline comments.Jul 7 2020, 1:36 AM
clang-tools-extra/clangd/tool/ClangdMain.cpp
700

should we first update the background index storage location?

kadircet accepted this revision.Jul 7 2020, 1:37 AM

LG from my side

This revision is now accepted and ready to land.Jul 7 2020, 1:37 AM
sammccall marked 4 inline comments as done.Jul 7 2020, 8:44 AM
sammccall added inline comments.
clang-tools-extra/clangd/tool/ClangdMain.cpp
436

I think this is the sort of detail best left to the actual documentation.
I've added a... forward declaration of that documentation here, to the URL where it will soon exist.

700

This is done. (There will still be old .clangd directories around, but that will ~always be true)

hokein accepted this revision.Jul 8 2020, 12:36 AM

looks like you didn't upload the latest version.

This revision was automatically updated to reflect the committed changes.
sammccall marked an inline comment as done.