This is an archive of the discontinued LLVM Phabricator instance.

[MLIR] Add an integration test for 2 D vector.transfer_read
ClosedPublic

Authored by AlexEichenberger on Jul 2 2020, 2:18 PM.

Details

Summary

Added a "clone" of the 1D vector's test_transfer_read and added a second dimensionality. The test is not as generic as I would like it to be, because more generic versions appear to break the compiler or the runtime at this stage. As bug are fixed, I will be happy to add another more complete test.

Diff Detail

Event Timeline

aartbik added inline comments.Jul 2 2020, 2:27 PM
mlir/integration_test/Dialect/Vector/CPU/test-transfer-read-2d.mlir
9

indentation

24

single break line

38

indentation

45

this comment seems left-over from the 1-D case, same below, at least make the 4x4 rows/columns clear in the comment

Generalized the test, can be easily modified to test other dimensions as needed

nicolasvasilache accepted this revision.Jul 3 2020, 2:56 PM
This revision is now accepted and ready to land.Jul 3 2020, 2:56 PM
aartbik accepted this revision.Jul 3 2020, 3:32 PM
aartbik added inline comments.
mlir/integration_test/Dialect/Vector/CPU/test-transfer-read-2d.mlir
43

nit: indent with 2, not 3, for consistency

I took the liberty to patch and land as I plan on using this and avoid reinventing the wheel.

Re:

more generic versions appear to break the compiler or the runtime at this stage. As bug are fixed, I will be happy to add another more complete test.

Could you please post some repros so we can look into it?

Thanks @AlexEichenberger !

The bug was on my side, I made it more generic. All is good.