Page MenuHomePhabricator

AlexEichenberger (Alexandre Eichenberger)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 1 2014, 1:52 PM (341 w, 6 d)

Recent Activity

Yesterday

AlexEichenberger requested review of D89726: MLIR: add ceil/floor divide in Standard Dialect.
Mon, Oct 19, 1:18 PM · Restricted Project

Thu, Oct 1

AlexEichenberger added a comment to D88532: [MLIR] Updates around MemRef Normalization.

Added suggestion, thanks for attempting to clarify the original text, much appreciated.

Thu, Oct 1, 7:25 AM · Restricted Project

Wed, Sep 23

AlexEichenberger accepted D88156: [mlir] Normalize memrefs in LoadOp and StoreOp of Standard Ops.

Thanks, glad to see that the traits make such changes easy... Please correct Uday's nit, and its good to go.

Wed, Sep 23, 9:37 AM · Restricted Project

Sep 18 2020

AlexEichenberger added a comment to D87746: [mlir] Fix of updating function signature in normalizing memrefs.

@imaihal Thanks for the upgrade. Minor nit still remains, please fix.

Sep 18 2020, 10:29 AM · Restricted Project, Restricted Project

Sep 9 2020

AlexEichenberger added a comment to D80695: [mlir] Convert raw data in dense element attributes into big-endian format..

Just my two cents; LE vs BE typically gives problem when a program read data with one data size, and write data with another size. So if the reader in the dense attributes respect the type size, namely read and write the data using the same format, and then generate the hex directly from the register content, then there are no issues with endianness.

Sep 9 2020, 10:31 AM · Restricted Project, Restricted Project

Sep 1 2020

AlexEichenberger added a comment to D80695: [mlir] Convert raw data in dense element attributes into big-endian format..

Rephrasing the question.

Sep 1 2020, 8:26 AM · Restricted Project, Restricted Project

Aug 27 2020

AlexEichenberger added a comment to D86236: MemRef Normalization for Dialects.

yes please.

Aug 27 2020, 6:16 AM · Restricted Project

Aug 26 2020

AlexEichenberger added a comment to D86236: MemRef Normalization for Dialects.

@bondhugula I don't believe I have commit privilege yet. Please commit for me, if you don't mind.

Aug 26 2020, 6:46 AM · Restricted Project

Aug 25 2020

AlexEichenberger added a comment to D86236: MemRef Normalization for Dialects.

Completed all current requests for changes.

Aug 25 2020, 12:24 PM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.
Aug 25 2020, 12:23 PM · Restricted Project
AlexEichenberger added a comment to D86236: MemRef Normalization for Dialects.

performed all requested changes but one. Left a clarification request for the suggestion that I am not sure to understand properly.

Aug 25 2020, 8:29 AM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.
Aug 25 2020, 8:21 AM · Restricted Project
AlexEichenberger added inline comments to D86236: MemRef Normalization for Dialects.
Aug 25 2020, 7:28 AM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.

Update to reflect latest comments.

Aug 25 2020, 7:26 AM · Restricted Project

Aug 24 2020

AlexEichenberger added a comment to D86236: MemRef Normalization for Dialects.
  1. Stretch question: do you see a scenario where some operand memrefs are normalizable but not others?

Since this 'MemRefsNormalizable' trait is more of "can/may be normalized" and is a first pass check because there are other things that could prevent it. For eg., CallOp is marked with this trait, but if a memref argument for the callee isn't normalizable due to a user op in that callee where it's not normalizable, that call op won't be normalized and transitively other ops won't be as well.

In the future or as a TODO, I think the right way to model this is using SideEffects, in particular, MemoryEffects (I briefly mentioned this on thread). This allows you to specify an effect at operand granularity. The design will require more thought though.

Aug 24 2020, 12:52 PM · Restricted Project
AlexEichenberger added inline comments to D86236: MemRef Normalization for Dialects.
Aug 24 2020, 12:50 PM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.

Implemented all of the requested changes. Introduced at TODO for partially normalizable operations.

Aug 24 2020, 12:47 PM · Restricted Project

Aug 20 2020

AlexEichenberger added inline comments to D86236: MemRef Normalization for Dialects.
Aug 20 2020, 12:10 PM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.

added proper order for traits

Aug 20 2020, 11:00 AM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.

Added revisions suggested for comments.

Aug 20 2020, 10:45 AM · Restricted Project
AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.

Added requested doc, edited the summary to be more specific with respect to the contribution of this patch, and removed a prior TODO with respect to recognizing operations that can be normalized by systematically using the new trait.

Aug 20 2020, 10:36 AM · Restricted Project

Aug 19 2020

AlexEichenberger updated the diff for D86236: MemRef Normalization for Dialects.

remove spurious commented code

Aug 19 2020, 12:13 PM · Restricted Project
AlexEichenberger requested review of D86236: MemRef Normalization for Dialects.
Aug 19 2020, 11:33 AM · Restricted Project
AlexEichenberger added a comment to D85885: [MLIR] Introduce memref vector cast op.

This functionality makes it very straightforward to develop SIMD code and replicate at a high level the ability to view memory as either scalar or SIMD code with very few restrictions.

Aug 19 2020, 7:24 AM · Restricted Project

Aug 18 2020

AlexEichenberger added a comment to D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

Once this patch is in, I have a follow on patch that introduces a new trait, MemRefNormalizable to be used by operations (such as DeallocOp, CallOp, ReturnOp) as well as any ops, for example, such as operations of an dialect that 1) will be expanded to external calls at some later time and 2) are ok with having their memrefs normalized to get rid of their maps.

Aug 18 2020, 1:10 PM · Restricted Project
AlexEichenberger added a comment to D84990: [MLIR] Simplify CmpIOp when operands are identical.

LGTM

Aug 18 2020, 8:51 AM · Restricted Project

Aug 13 2020

AlexEichenberger added a comment to D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

Looking into extending this approach to handle dialect ops that will become calls to external functions. Specifically, I am looking for a way to express that an operation guarantees that (when it will be lowered to an external function call), the external function be aware of the data layout of the maps and thus it is safe to normalize the op memref parameters.

Aug 13 2020, 7:53 AM · Restricted Project

Aug 11 2020

AlexEichenberger added a comment to D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

@bondhugula Static is easy. We are working on making it work for the dynamic shapes, currently in our code base but we could migrate it to the MLIR as part of another patch. Basically, we go back to the alloc responsible for the array, and parse the memref to pick either a constant or the right alloc parameter corresponding to the n th '?' in the memref of the alloc.

Aug 11 2020, 5:56 PM · Restricted Project
AlexEichenberger added a comment to D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

I tried the patch and this simple code appears to disable memref normalization

Aug 11 2020, 6:39 AM · Restricted Project

Aug 9 2020

AlexEichenberger added a comment to D85226: [MLIR] Support for ReturnOps in memref map layout normalization.

The code looks good, and I like the addition of skipping the analysis for "extern" functions. Because dialect ops can in some ways also represent "future" external functions, a natural way of handling "not yet expanded" external functions would to add an interface query that ask if a given op is "external" also. Default would be false, and dialects that needs dome/all of their ops to be external would be able to refine the interface to provide the necessary functionality.

Aug 9 2020, 7:48 AM · Restricted Project

Aug 4 2020

AlexEichenberger added a comment to D83096: [MLIR] Add an integration test for 2 D vector.transfer_read.

The bug was on my side, I made it more generic. All is good.

Aug 4 2020, 6:38 AM · Restricted Project

Jul 29 2020

AlexEichenberger added a comment to D84490: [MLIR] Introduce inter-procedural memref layout normalization.

@AlexEichenberger : Such operation handling can be a part of subsequent revision.
Thank you.

Jul 29 2020, 9:24 AM · Restricted Project

Jul 28 2020

AlexEichenberger added a comment to D84490: [MLIR] Introduce inter-procedural memref layout normalization.

This patch does the advertised functionality well, as shown with the little example below:

Jul 28 2020, 7:42 AM · Restricted Project
AlexEichenberger accepted D84490: [MLIR] Introduce inter-procedural memref layout normalization.

sorry, requested a revision by mistake. Repost as a comment below

Jul 28 2020, 7:40 AM · Restricted Project
AlexEichenberger requested changes to D84490: [MLIR] Introduce inter-procedural memref layout normalization.
Jul 28 2020, 7:33 AM · Restricted Project

Jul 3 2020

AlexEichenberger updated the diff for D83096: [MLIR] Add an integration test for 2 D vector.transfer_read.

Generalized the test, can be easily modified to test other dimensions as needed

Jul 3 2020, 12:24 PM · Restricted Project

Jul 2 2020

AlexEichenberger created D83096: [MLIR] Add an integration test for 2 D vector.transfer_read.
Jul 2 2020, 2:36 PM · Restricted Project

Jun 22 2020

AlexEichenberger added a comment to D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.

code is ready to be dropped, since I don't have commit privilege, can you please assist, thanks.

Jun 22 2020, 8:35 AM · Restricted Project

Jun 19 2020

AlexEichenberger updated the diff for D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.
Jun 19 2020, 7:32 PM · Restricted Project
AlexEichenberger updated the diff for D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.

Addressed latest spelling requests. I do need help to commit changes, did a few sometimes ago, not sure how to do it now.

Jun 19 2020, 7:32 PM · Restricted Project
AlexEichenberger added a comment to D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.

now all comments are done.

Jun 19 2020, 7:32 PM · Restricted Project
AlexEichenberger updated the diff for D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.

latest comments addressed

Jun 19 2020, 7:00 PM · Restricted Project
AlexEichenberger updated the diff for D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.

Added the requested lit tests

Jun 19 2020, 9:12 AM · Restricted Project

Jun 18 2020

AlexEichenberger added a comment to D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.

I added the { and } around the if statement specifically to avoid name conflicts. I don't like assignment in if-conditional, but since it's both legal and machine generated code (not intended for human consumption), I think it's ok.

Jun 18 2020, 10:54 AM · Restricted Project
AlexEichenberger created D82101: [MLIR] Remove TableGen redundant calls to native calls when creating new operations in DRR TableGen files.
Jun 18 2020, 8:40 AM · Restricted Project
AlexEichenberger committed rG3e34a9a14d0f: Merge branch 'master' into tblgen-rewrite-no-redundant-native-call (authored by AlexEichenberger).
Merge branch 'master' into tblgen-rewrite-no-redundant-native-call
Jun 18 2020, 7:42 AM
GitHub <noreply@github.com> committed rG28399fab80e5: Merge 3e34a9a14d0fd74e48c9e7b6801d2ece8cac868d into… (authored by AlexEichenberger).
Merge 3e34a9a14d0fd74e48c9e7b6801d2ece8cac868d into…
Jun 18 2020, 7:36 AM
AlexEichenberger committed rGf0e13c3206fc: remove redundant native calls in DRR (authored by AlexEichenberger).
remove redundant native calls in DRR
Jun 18 2020, 7:36 AM

Feb 18 2020

AlexEichenberger added a comment to D74143: [MLIR] Adding attribute setters generation for table gen.

What do you suggest I do? Would you like me to introduce the get and set, and leave the older methods for deprecation? Or only add the setter with "set" in the name?

Feb 18 2020, 8:17 AM · Restricted Project

Feb 14 2020

AlexEichenberger added inline comments to D74143: [MLIR] Adding attribute setters generation for table gen.
Feb 14 2020, 12:30 PM · Restricted Project

Feb 11 2020

AlexEichenberger updated the diff for D74143: [MLIR] Adding attribute setters generation for table gen.
Feb 11 2020, 11:19 AM · Restricted Project

Feb 10 2020

AlexEichenberger added a comment to D74143: [MLIR] Adding attribute setters generation for table gen.

tx for the valuable input

Feb 10 2020, 2:51 PM · Restricted Project
AlexEichenberger updated the diff for D74143: [MLIR] Adding attribute setters generation for table gen.

added tests of setters, removed unneeded code, edited & migrated comments as requested

Feb 10 2020, 2:51 PM · Restricted Project

Feb 7 2020

AlexEichenberger added inline comments to D74143: [MLIR] Adding attribute setters generation for table gen.
Feb 7 2020, 11:39 AM · Restricted Project
AlexEichenberger updated the diff for D74143: [MLIR] Adding attribute setters generation for table gen.

updated style

Feb 7 2020, 11:39 AM · Restricted Project

Feb 6 2020

AlexEichenberger created D74143: [MLIR] Adding attribute setters generation for table gen.
Feb 6 2020, 10:29 AM · Restricted Project

Dec 23 2019

A. Unique TensorFlower <gardener@tensorflow.org> committed rG3c69ca1e6966: fix examples in comments (authored by AlexEichenberger).
fix examples in comments
Dec 23 2019, 9:20 PM

Jul 31 2019

AlexEichenberger accepted D65340: [OpenMP][libomptarget] Add support for close map modifier.

LGTM

Jul 31 2019, 1:49 PM · Restricted Project, Restricted Project

Jul 29 2019

AlexEichenberger added inline comments to D65001: [OpenMP][libomptarget] Add support for unified memory for regular maps.
Jul 29 2019, 2:36 PM · Restricted Project, Restricted Project

Jun 14 2019

AlexEichenberger added inline comments to D63009: [OpenMP] Add target task alloc function with device ID.
Jun 14 2019, 12:02 PM · Restricted Project, Restricted Project, Restricted Project

Jun 12 2019

AlexEichenberger accepted D63009: [OpenMP] Add target task alloc function with device ID.

LGTM

Jun 12 2019, 10:44 AM · Restricted Project, Restricted Project, Restricted Project

Jun 11 2019

AlexEichenberger accepted D63010: [OpenMP] Add task alloc function.

LGTM

Jun 11 2019, 1:59 PM · Restricted Project, Restricted Project, Restricted Project

Jun 10 2019

AlexEichenberger added inline comments to D63010: [OpenMP] Add task alloc function.
Jun 10 2019, 8:35 AM · Restricted Project, Restricted Project, Restricted Project
AlexEichenberger added inline comments to D63009: [OpenMP] Add target task alloc function with device ID.
Jun 10 2019, 8:35 AM · Restricted Project, Restricted Project, Restricted Project

Apr 16 2019

AlexEichenberger accepted D60568: [OpenMP] Add support for registering requires directives with the runtime.

fantastic

Apr 16 2019, 12:18 PM · Restricted Project, Restricted Project
AlexEichenberger added a comment to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries..

response to Alexey's comment

Apr 16 2019, 11:16 AM · Restricted Project
AlexEichenberger accepted D60223: [OpenMP][libomptarget] Enable requires flags for target libraries..

LGTM, just made one minor suggestion

Apr 16 2019, 11:15 AM · Restricted Project

Apr 12 2019

AlexEichenberger requested changes to D60568: [OpenMP] Add support for registering requires directives with the runtime.

see note above; apologies if it is already done and hiding somewhere I did not see

Apr 12 2019, 6:17 AM · Restricted Project, Restricted Project

Apr 8 2019

AlexEichenberger requested changes to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries..

See suggested changes, should be pretty straightforward to do, let me know if you need help

Apr 8 2019, 2:28 PM · Restricted Project

Apr 3 2019

AlexEichenberger requested changes to D60223: [OpenMP][libomptarget] Enable requires flags for target libraries..

see comments

Apr 3 2019, 12:23 PM · Restricted Project

Sep 4 2018

AlexEichenberger added a comment to D51623: [libomptarget] PR38704: Fix erase of ShadowPtrMap.

make sense, thanks

Sep 4 2018, 10:05 AM

Aug 27 2018

AlexEichenberger added a comment to D51285: Fix a build issue on Debian Jessie.

Yes, we should have done this right away. I did a rewrite of the functionality that uses header files already included; it was posted in D50522 and the changes were approved and pushed to svn.

Aug 27 2018, 8:01 PM
AlexEichenberger committed rL340767: [OpenMP][libomptarget] rework of fatal error reporting.
[OpenMP][libomptarget] rework of fatal error reporting
Aug 27 2018, 11:22 AM
AlexEichenberger committed rOMP340767: [OpenMP][libomptarget] rework of fatal error reporting.
[OpenMP][libomptarget] rework of fatal error reporting
Aug 27 2018, 11:22 AM
AlexEichenberger closed D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 27 2018, 11:22 AM
AlexEichenberger added inline comments to D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 27 2018, 8:10 AM
AlexEichenberger updated the diff for D51226: [OpenMP][libomptarget] rework of fatal error reporting.
  • Merge branch 'unpatched-master' into unpatched-master-target-offload-envvar
  • while (0) edit
Aug 27 2018, 8:09 AM

Aug 26 2018

AlexEichenberger updated the diff for D51226: [OpenMP][libomptarget] rework of fatal error reporting.
  • added do while(1) for macros
Aug 26 2018, 7:07 PM

Aug 24 2018

AlexEichenberger updated the diff for D51226: [OpenMP][libomptarget] rework of fatal error reporting.
  • put fatal message for default tgt test
Aug 24 2018, 5:55 PM
AlexEichenberger added inline comments to D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 24 2018, 2:12 PM
AlexEichenberger added inline comments to D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 24 2018, 12:00 PM
AlexEichenberger added a comment to D51226: [OpenMP][libomptarget] rework of fatal error reporting.

Alexey was not happy about adding an include, and we already used the define approach for the debug messages. So we reuse the same functionality that we already used for debug.
Agreed that Johnas suggested it, and given the problem with the include, Alexey urged me to change the code to what we have here.

Aug 24 2018, 11:40 AM
AlexEichenberger added a comment to D51226: [OpenMP][libomptarget] rework of fatal error reporting.

I don't understand this: In the last review you said that we need the complicated FatalMessage and now you are reverting that?!?

Aug 24 2018, 10:49 AM
AlexEichenberger updated the diff for D51226: [OpenMP][libomptarget] rework of fatal error reporting.
  • format
Aug 24 2018, 10:46 AM
AlexEichenberger added a comment to D51219: [OpenMP] Add missing header. va_start, va_end undeclared in gcc 5.5.0.

I reworked the solution to avoid varargs, and proposed a more robust solution in D51226

Aug 24 2018, 10:38 AM
AlexEichenberger retitled D51226: [OpenMP][libomptarget] rework of fatal error reporting from [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var to [OpenMP][libomptarget] rework of fatal error reporting.
Aug 24 2018, 10:36 AM
AlexEichenberger created D51226: [OpenMP][libomptarget] rework of fatal error reporting.
Aug 24 2018, 10:34 AM

Aug 23 2018

AlexEichenberger added a comment to D51107: [LIBOMPTARGET] Add support for mapping of lambda captures..
Aug 23 2018, 8:05 PM
AlexEichenberger committed rL340542: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD….
[OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD…
Aug 23 2018, 9:23 AM
AlexEichenberger committed rOMP340542: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD….
[OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD…
Aug 23 2018, 9:23 AM
AlexEichenberger closed D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.
Aug 23 2018, 9:23 AM
AlexEichenberger added inline comments to D51107: [LIBOMPTARGET] Add support for mapping of lambda captures..
Aug 23 2018, 7:20 AM

Aug 16 2018

AlexEichenberger updated the diff for D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

Thanks to all for your valuable comments, much appreciated, really contributed to the quality of the patch

Aug 16 2018, 6:26 AM

Aug 15 2018

AlexEichenberger added a comment to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

updated comments status

Aug 15 2018, 8:30 AM
AlexEichenberger updated the diff for D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

fixed clang-format and moved fatal message function

Aug 15 2018, 8:28 AM

Aug 14 2018

AlexEichenberger added inline comments to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.
Aug 14 2018, 8:48 PM
AlexEichenberger added a comment to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

responded to comments

Aug 14 2018, 1:00 PM
AlexEichenberger updated the diff for D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

implemented suggest changes

Aug 14 2018, 12:55 PM
AlexEichenberger added a comment to D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

responded to comments.

Aug 14 2018, 9:31 AM
AlexEichenberger updated the diff for D50522: [OpenMP][libomptarget] Bringing up to spec with respect to OMP_TARGET_OFFLOAD env var.

Addressed all remaining issues

Aug 14 2018, 9:28 AM