Page MenuHomePhabricator
Differential D82819

[ods] Update Operator to record Arg->[Attr|Operand]Index mapping
ClosedPublic
Actions

Authored by jpienaar on Jun 29 2020, 3:47 PM.

Details

Reviewers
rriddle
antiagainst
Commits
rG71b9d89df78f: [ods] Update Operator to record Arg->[Attr|Operand]Index mapping
Summary

Also fixed bug in type inferface generator to address bug where operands and
attributes are interleaved.

Diff Detail

Event Timeline

jpienaar created this revision.Jun 29 2020, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2020, 3:47 PM
Herald added subscribers: msifontes, jurahul, Kayjukh and 12 others. · View Herald Transcript
rriddle accepted this revision.Jun 29 2020, 3:54 PM
rriddle added inline comments.
mlir/include/mlir/TableGen/Operator.h
266

nit: Can you bitpack these together?

270

nit: argument at index?

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
1605

nit: Drop the mir::.

This revision is now accepted and ready to land.Jun 29 2020, 3:54 PM
Harbormaster completed remote builds in B62238: Diff 274272.Jun 29 2020, 4:06 PM
jpienaar updated this revision to Diff 274280.Jun 29 2020, 4:10 PM
jpienaar marked 3 inline comments as done.

Packed to one int with member accessors.

Harbormaster completed remote builds in B62242: Diff 274280.Jun 29 2020, 4:39 PM
Closed by commit rG71b9d89df78f: [ods] Update Operator to record Arg->[Attr|Operand]Index mapping (authored by jpienaar). · Explain WhyJun 29 2020, 4:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
TableGen/
12 lines
lib/
TableGen/
9 lines
test/
mlir-tblgen/
13 lines
tools/
mlir-tblgen/
7 lines

Diff 274272

View Options

mlir/include/mlir/TableGen/Operator.h

Loading...
View Options

mlir/lib/TableGen/Operator.cpp

Loading...
View Options

mlir/test/mlir-tblgen/op-result.td

Loading...
View Options

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp

Loading...