Page MenuHomePhabricator

[ods] Update Operator to record Arg->[Attr|Operand]Index mapping
ClosedPublic

Authored by jpienaar on Mon, Jun 29, 3:47 PM.

Details

Summary

Also fixed bug in type inferface generator to address bug where operands and
attributes are interleaved.

Diff Detail

Event Timeline

jpienaar created this revision.Mon, Jun 29, 3:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptMon, Jun 29, 3:47 PM
rriddle accepted this revision.Mon, Jun 29, 3:54 PM
rriddle added inline comments.
mlir/include/mlir/TableGen/Operator.h
266

nit: Can you bitpack these together?

270

nit: argument at index?

mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp
1605

nit: Drop the mir::.

This revision is now accepted and ready to land.Mon, Jun 29, 3:54 PM
jpienaar updated this revision to Diff 274280.Mon, Jun 29, 4:10 PM
jpienaar marked 3 inline comments as done.

Packed to one int with member accessors.

This revision was automatically updated to reflect the committed changes.