Page MenuHomePhabricator

AMDGPU: Remove .value_type from kernel metadata
ClosedPublic

Authored by arsenm on Jun 29 2020, 3:45 PM.

Details

Summary

This doesn't appear used for anything, and is emitted incorrectly
based on the description. This also depends on the IR type, and
pointee element type.

Diff Detail

Event Timeline

arsenm created this revision.Jun 29 2020, 3:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2020, 3:45 PM
arsenm added a comment.Jul 6 2020, 2:09 PM

Patch committed to remove the use from rocclr

Do we also want to remove it from v2 metadata?

arsenm added a comment.Jul 9 2020, 9:25 AM

Do we also want to remove it from v2 metadata?

Probably, but I looked briefly and didn't actually see the direct equivalent

Do we also want to remove it from v2 metadata?

Probably, but I looked briefly and didn't actually see the direct equivalent

It's "ValueType" in the v2 metadata.

arsenm updated this revision to Diff 276843.Jul 9 2020, 2:42 PM

Remove v2, and also accept parsing

scott.linder added inline comments.Jul 9 2020, 3:25 PM
llvm/docs/AMDGPUUsage.rst
2320–2321

Should we delete this as well? Or at least mark it as non-Required?

arsenm updated this revision to Diff 276854.Jul 9 2020, 3:31 PM

Update documentation

kzhuravl added inline comments.Jul 10 2020, 7:58 AM
llvm/docs/AMDGPUUsage.rst
2321

It looks like (according to phab diff) you removed space between "ValueType" and 'string', which will break the table.

2322

compatibility

2820–2842

Should same text apply as above? "Unused and deprecated. This should no longer..."

llvm/include/llvm/Support/AMDGPUMetadata.h
82–83

compatibility

llvm/lib/Support/AMDGPUMetadata.cpp
115

same as above

arsenm updated this revision to Diff 277094.Jul 10 2020, 10:27 AM
arsenm marked 2 inline comments as done.

Documentation fixes

This revision is now accepted and ready to land.Jul 10 2020, 10:30 AM