This is an archive of the discontinued LLVM Phabricator instance.

[libc++abi] Remove unused include of <sys/types.h>
ClosedPublic

Authored by ldionne on Jun 29 2020, 2:46 PM.

Details

Reviewers
EricWF
compnerd
Group Reviewers
Restricted Project
Commits
rGc2547f1554d3: [libc++abi] Remove unused include of <sys/types.h>
Summary

I ran into an error while trying to build libc++abi for a platform that
doesn't have <sys/types.h>. I couldn't find what <sys/types.h> was used
for in the header, so I think it's fine to remove it.

Diff Detail

Event Timeline

ldionne created this revision.Jun 29 2020, 2:46 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2020, 2:46 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added a subscriber: EricWF.

Adding @EricWF since he wrote this.

compnerd accepted this revision.Jun 30 2020, 8:31 AM
compnerd added a subscriber: compnerd.

I agree, as long as declarations are available this should be fine. Even better - this is in the src tree, so we don't even have to worry about users.

Might be useful to just run IWYU over the tree at some point to remove extraneous headers.

This revision is now accepted and ready to land.Jun 30 2020, 8:31 AM

Might be useful to just run IWYU over the tree at some point to remove extraneous headers.

As long as no one deletes includes that may not be used, but are mandated by the standard.

This revision was automatically updated to reflect the committed changes.