- svget2/3/4
- svset2/3/4
- svcreate2/3/4
- svundef/2/3/4
Details
Diff Detail
Event Timeline
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_create2-bfloat.c | ||
---|---|---|
10 | Nit: these are all new files, so you can safely use clang-format on them, as they will not modify the formatting of pre-existing tests. I know this is not what we have done for most of the files in the ACLE tests, but it makes life so much easier to just run a git clang-format HEAD^ on a patch and kinda forgetting about formatting! Since they are new files, they will not generate conflicts with anything we might have downstream. FWIW, this is my personal preference, so if you prefer to adhere with the manual formatting of other files, I am happy with it. | |
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_get2-bfloat.c | ||
21 | Shouldn't we test also values other then zero? 0,1 for get2, 0,1,2 for get3... |
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_create2-bfloat.c | ||
---|---|---|
10 | I agree it's nice to be able to use clang-format and not think about it but in my opinion it's more important to be consistent in formatting across the ACLE tests. I'd prefer a follow-up patch once the ACLE is complete containing the diff produced from running clang-format on clang/test/CodeGen/aarch64-sve-intrinsics / clang/test/CodeGen/aarch64-sve2-intrinsics. | |
clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_get2-bfloat.c | ||
21 |
We have coverage for all valid indexes in the test suite for these intrinsics, I was about to say it's the same code path regardless of type, which it is on the LLVM side but the intrinsic defs in clang are split so I guess that isn't covered. I'll add extra tests. |
llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll | ||
---|---|---|
1 | I think you should use the function attribute trick in this test, not the command line option, like we have done in other tests. | |
100 | nit: remove local_unnamed_addr from all tests you have added. | |
109 | out of curiosity.... why not test the create intrinsic directly? |
Nit: these are all new files, so you can safely use clang-format on them, as they will not modify the formatting of pre-existing tests. I know this is not what we have done for most of the files in the ACLE tests, but it makes life so much easier to just run a git clang-format HEAD^ on a patch and kinda forgetting about formatting! Since they are new files, they will not generate conflicts with anything we might have downstream. FWIW, this is my personal preference, so if you prefer to adhere with the manual formatting of other files, I am happy with it.