This is an archive of the discontinued LLVM Phabricator instance.

[NewPM][BasicAA] Rename basicaa -> basic-aa, add alias
ClosedPublic

Authored by aeubanks on Jun 25 2020, 3:30 PM.

Details

Summary

BasicAA under the new pass manager is called "basic-aa", which fits more
with the other AA names which almost always contain a dash.

Keep an alias from basicaa -> basic-aa.

Will change all references of "basicaa" to "basic-aa", then remove the
alias.

Makes check-llvm failures under NPM go from 2307 to 1867.

Diff Detail

Event Timeline

aeubanks created this revision.Jun 25 2020, 3:30 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 25 2020, 3:30 PM
ychen added inline comments.Jun 25 2020, 4:36 PM
llvm/lib/IR/Pass.cpp
27

LGTM. Why this?

aeubanks updated this revision to Diff 273560.Jun 25 2020, 5:04 PM
aeubanks marked an inline comment as done.

Remove include left over from previous work

ychen accepted this revision.Jun 25 2020, 5:45 PM

LGTM

This revision is now accepted and ready to land.Jun 25 2020, 5:45 PM

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.

This revision was automatically updated to reflect the committed changes.
ychen added a comment.Jun 25 2020, 6:42 PM

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.

Quick question: how to generate Reviewed by in place with commits that are uploaded by arc diff. I have to do arc patch to get the Review by which is not convenient.

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.

Quick question: how to generate Reviewed by in place with commits that are uploaded by arc diff. I have to do arc patch to get the Review by which is not convenient.

+1.

I'll try to get the pre-push hooks working, although it might be tricky on Windows, and easier to forget to setup since I use multiple git worktrees on multiple machines.

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.

Quick question: how to generate Reviewed by in place with commits that are uploaded by arc diff. I have to do arc patch to get the Review by which is not convenient.

arc amend amends the description with Reviewed By: and other tags.

ychen added a comment.Jun 26 2020, 2:38 PM

Hi, your git commit contains extra Phabricator tags. You can drop Reviewers: Subscribers: Tags: and the text Summary: from the git commit with the following script:

arcfilter () {
        arc amend
        git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend --date=now -F -
}

Reviewed By: is considered important by some people. Please keep the tag. (I have updated my script to use --date=now (setting author date to committer date))

https://reviews.llvm.org/D80978 contains a git pre-push hook to automate this.

Quick question: how to generate Reviewed by in place with commits that are uploaded by arc diff. I have to do arc patch to get the Review by which is not convenient.

arc amend amends the description with Reviewed By: and other tags.

Thank you!