This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] OpenMP Clang tests without 50 version string after upgrading to 5.0
AbandonedPublic

Authored by saiislam on Jun 25 2020, 9:18 AM.

Details

Summary

Follow up of D81098 to ensure that no test silently fails during
next OpenMP version bump. This patch removes all occurrences of
-fopenmp-version=50 from all test files.

Any future commits causing divergent behavior from 5.0 may
use version string for tagging version specific behavior while
keeping test for default version without version string.

Diff Detail

Event Timeline

saiislam created this revision.Jun 25 2020, 9:18 AM
saiislam updated this revision to Diff 274792.Jul 1 2020, 6:58 AM

[Work in progress] 48 files inspected/corrected. Following 35 are yet to be checked:

clang/test/OpenMP/target_parallel_depend_messages.cpp (26 lines)
clang/test/OpenMP/target_parallel_for_depend_messages.cpp (53 lines)
clang/test/OpenMP/target_parallel_for_map_messages.cpp (17 lines)
clang/test/OpenMP/target_parallel_for_simd_depend_messages.cpp (53 lines)
clang/test/OpenMP/target_parallel_for_simd_is_device_ptr_messages.cpp (15 lines)
clang/test/OpenMP/target_parallel_for_simd_map_messages.cpp (17 lines)
clang/test/OpenMP/target_parallel_is_device_ptr_messages.cpp (10 lines)
clang/test/OpenMP/target_parallel_map_messages.cpp (14 lines)
clang/test/OpenMP/target_simd_depend_codegen.cpp (12 lines)
clang/test/OpenMP/target_simd_depend_messages.cpp (53 lines)
clang/test/OpenMP/target_simd_map_messages.cpp (17 lines)
clang/test/OpenMP/target_teams_depend_messages.cpp (22 lines)
clang/test/OpenMP/target_teams_distribute_depend_messages.cpp (33 lines)
clang/test/OpenMP/target_teams_distribute_map_messages.cpp (17 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_depend_messages.cpp (42 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_is_device_ptr_messages.cpp (10 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_map_messages.cpp (13 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_schedule_codegen.cpp (48 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_depend_messages.cpp (42 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_firstprivate_messages.cpp (11 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_is_device_ptr_messages.cpp (11 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_map_messages.cpp (14 lines)
clang/test/OpenMP/target_teams_distribute_parallel_for_simd_schedule_codegen.cpp (48 lines)
clang/test/OpenMP/target_teams_distribute_simd_depend_codegen.cpp (99 lines)
clang/test/OpenMP/target_teams_distribute_simd_depend_messages.cpp (33 lines)
clang/test/OpenMP/target_teams_distribute_simd_is_device_ptr_messages.cpp (14 lines)
clang/test/OpenMP/target_teams_distribute_simd_loop_messages.cpp (34 lines)
clang/test/OpenMP/target_teams_distribute_simd_map_messages.cpp (17 lines)
clang/test/OpenMP/target_teams_is_device_ptr_messages.cpp (14 lines)
clang/test/OpenMP/target_update_depend_messages.cpp (131 lines)
clang/test/OpenMP/teams_distribute_parallel_for_schedule_codegen.cpp (48 lines)
clang/test/OpenMP/teams_distribute_parallel_for_simd_firstprivate_messages.cpp (11 lines)
clang/test/OpenMP/teams_distribute_parallel_for_simd_schedule_codegen.cpp (44 lines)
clang/test/OpenMP/teams_distribute_simd_firstprivate_messages.cpp (10 lines)
clang/test/OpenMP/threadprivate_codegen.cpp (330 lines)

saiislam updated this revision to Diff 278079.Jul 14 2020, 11:44 PM

Instead of adding additional test cases without version string, removed all occurrences of -fopenmp-version=50.

saiislam retitled this revision from [OpenMP] Additional OpenMP test without version string after upgrading to 5.0 to [OpenMP] OpenMP Clang tests without 50 version string after upgrading to 5.0.Jul 14 2020, 11:56 PM
saiislam edited the summary of this revision. (Show Details)

Check that default tests have additional -fopenmp-version=45 flag since they are expected to be executed in OpenMP 4.5 mode.

clang/test/OpenMP/declare_target_ast_print.cpp
5–7 ↗(On Diff #278079)

Previous RUN lines miss -fopenmp-version=45

clang/test/OpenMP/distribute_codegen.cpp
14 ↗(On Diff #278079)

Previous RUN lines miss -fopenmp-version=45

24–29 ↗(On Diff #278079)

Previous RUN lines miss -fopenmp-version=45

clang/test/OpenMP/distribute_simd_codegen.cpp
2–7 ↗(On Diff #278079)

Missed -fopenmp-version=45

saiislam abandoned this revision.Aug 4 2020, 8:25 AM

Abandoning in favor of D85214