Page MenuHomePhabricator

[LLDB][NFC] Remove redundant condition
ClosedPublic

Authored by baloghadamsoftware on Jun 25 2020, 8:02 AM.

Details

Summary

Condition auto_advance_pc is checked both in an outer and in an inner if statement in EmulateInstructionARM::EvaluateInstruction(), EmulateInstructionARM64::EvaluateInstruction() and EmulateInstructionPPC64::EvaluateInstruction(). This patch removes the redundant inner check.

The issue was found using clang-tidy check under review misc-redundant-condition. See https://reviews.llvm.org/D81272.

Diff Detail

Event Timeline

labath accepted this revision.Jun 26 2020, 1:44 AM
This revision is now accepted and ready to land.Jun 26 2020, 1:44 AM
clayborg accepted this revision.Jun 26 2020, 2:11 PM
This revision was automatically updated to reflect the committed changes.