[LLDB][NFC] Remove redundant condition

[baloghadamsoftware]

Summary

Condition auto_advance_pc is checked both in an outer and in an inner if statement in EmulateInstructionARM::EvaluateInstruction(), EmulateInstructionARM64::EvaluateInstruction() and EmulateInstructionPPC64::EvaluateInstruction(). This patch removes the redundant inner check.

The issue was found using clang-tidy check under review misc-redundant-condition. See https://reviews.llvm.org/D81272.

lldb/source/Plugins/Instruction/ARM/EmulateInstructionARM.cpp

if (m_opcode_mode == eModeThumb && m_it_session.InITBlock() &&
     m_it_session.ITAdvance();
 
   if (auto_advance_pc) {
     uint32_t after_pc_value =
         ReadRegisterUnsigned(eRegisterKindDWARF, dwarf_pc, 0, &success);
     if (!success)
       return false;
 
-    if (auto_advance_pc && (after_pc_value == orig_pc_value)) {
+    if (after_pc_value == orig_pc_value) {
       after_pc_value += m_opcode.GetByteSize();
 
       EmulateInstruction::Context context;
       context.type = eContextAdvancePC;
       context.SetNoArgs();
       if (!WriteRegisterUnsigned(context, eRegisterKindDWARF, dwarf_pc,
                                  after_pc_value))
         return false;

lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp

if (!success)
     return false;
 
   if (auto_advance_pc) {
     uint32_t new_pc_value =
         ReadRegisterUnsigned(eRegisterKindLLDB, gpr_pc_arm64, 0, &success);
     if (!success)
       return false;
 
-    if (auto_advance_pc && (new_pc_value == orig_pc_value)) {
+    if (new_pc_value == orig_pc_value) {
       EmulateInstruction::Context context;
       context.type = eContextAdvancePC;
       context.SetNoArgs();
       if (!WriteRegisterUnsigned(context, eRegisterKindLLDB, gpr_pc_arm64,
                                  orig_pc_value + 4))
         return false;
     }
   }

lldb/source/Plugins/Instruction/PPC64/EmulateInstructionPPC64.cpp

if (!success)
     return false;
 
   if (auto_advance_pc) {
     uint32_t new_pc_value =
         ReadRegisterUnsigned(eRegisterKindLLDB, gpr_pc_ppc64le, 0, &success);
     if (!success)
       return false;
 
-    if (auto_advance_pc && (new_pc_value == orig_pc_value)) {
+    if (new_pc_value == orig_pc_value) {
       EmulateInstruction::Context context;
       context.type = eContextAdvancePC;
       context.SetNoArgs();
       if (!WriteRegisterUnsigned(context, eRegisterKindLLDB, gpr_pc_ppc64le,
                                  orig_pc_value + 4))
         return false;
     }
   }