This is an archive of the discontinued LLVM Phabricator instance.

Refactor FunctionPropertiesAnalysis
ClosedPublic

Authored by tarinduj on Jun 24 2020, 11:36 PM.

Details

Summary

this separates analyze logic from FunctionPropertiesAnalysis

Diff Detail

Event Timeline

tarinduj created this revision.Jun 24 2020, 11:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptJun 24 2020, 11:36 PM
tarinduj updated this revision to Diff 273230.Jun 24 2020, 11:53 PM
mtrofin added inline comments.Jun 25 2020, 8:16 AM
llvm/include/llvm/Analysis/ML/FunctionPropertiesAnalysis.h
44

I think (D82270) we were saying we would have a static factory method in FunctionPropertiesInfo, instead of a member. We'd then (maybe later CL) try to treat a FunctionPropertiesInfo instance as immutable.

tarinduj updated this revision to Diff 273440.Jun 25 2020, 10:17 AM

added a static factory method getFunctionPropertiesInfo.

This revision is now accepted and ready to land.Jun 25 2020, 10:56 AM
tarinduj updated this revision to Diff 279830.Jul 22 2020, 8:24 AM
tarinduj marked an inline comment as done.

[rebased] can someone upstream this? I do not have commit access.

This revision was automatically updated to reflect the committed changes.